Skip to content

#2494 Fix: Captcha field missing when returning to UIN entry page after OTP verification failure. - #2557

Open
SajidMannikeri17 wants to merge 1 commit into
mosip:develop-gofrom
Infosys:fix/2494
Open

SajidMannikeri17 wants to merge 1 commit into
mosip:develop-gofrom
Infosys:fix/2494

Conversation

@SajidMannikeri17

@SajidMannikeri17 SajidMannikeri17 commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Related Issue: #2494

Summary by CodeRabbit

  • Bug Fixes
    • Captcha information is now cleared when returning from the OTP screen to the identifier prompt, alongside the username.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 1826d82e-72db-44a5-8af3-5634cb235db3

📥 Commits

Reviewing files that changed from the base of the PR and between 0ab378a and 035d7d4.

📒 Files selected for processing (1)
  • esignet-service/data/flows/flow-esignet.yaml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 8c4cce3c-e4dd-4849-947c-8cd3b79fe146

📥 Commits

Reviewing files that changed from the base of the PR and between c381283 and 0ab378a.

📒 Files selected for processing (1)
  • esignet-service/data/flows/flow-esignet.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The OTP reset flow now clears the captcha token together with the username when it returns to the identifier prompt.

Changes

OTP reset flow

Layer / File(s) Summary
Clear OTP inputs
esignet-service/data/flows/flow-esignet.yaml
The clear_otp_username executor now clears the CAPTCHA_BOX value identified as captcha_token along with username.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: zesu22, anushasunkada, sacrana0

Merge Risk: ⚪ Minimal · up to 0ab37

The OTP reset path now clears the CAPTCHA token so the identifier page can render its CAPTCHA field again after OTP failure. No concrete merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the CAPTCHA restoration issue after OTP verification failure and matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

The username fades away,
The captcha token follows its trail,
The prompt begins anew,
Clean inputs guide the flow,
A fresh start waits in view.

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Sep 8, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop-go@cddeea0). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop-go    #2557   +/-   ##
=============================================
  Coverage              ?   70.36%           
=============================================
  Files                 ?      130           
  Lines                 ?     9003           
  Branches              ?      114           
=============================================
  Hits                  ?     6335           
  Misses                ?     2206           
  Partials              ?      462           
Flag Coverage Δ
go 69.19% <ø> (?)
npm 92.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread esignet-service/data/flows/flow-esignet.yaml

@zesu22 zesu22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Signed-off-by: SajidMannikeri17 <sajid.mannikeri@infosys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants