Bugfix FXIOS-15625 [ETP] Refresh certificate screen theme on system appearance changes#34024
Open
Kartikayy007 wants to merge 3 commits into
Open
Conversation
…ppearance changes
Kartikayy007
changed the title
Contributor
Author
|
@mattreaganmozilla please review |
Contributor
Author
|
@FilippoZazzeroni please review |
Contributor
|
This pull request has conflicts when rebasing. Could you fix it @Kartikayy007? 🙏 |
…te-theme-refresh # Conflicts: # firefox-ios/Client.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Collaborator
|
Thanks @mattreaganmozilla for taking over on the review, sorry @Kartikayy007 for not reviewing it i was out the past week. |
Contributor
Author
|
@mattreaganmozilla ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Refreshes the certificate screen theme when system appearance changes. The certificate table now updates its background, separator color, and reloads its rows so certificate details use the current theme.
🎥 Demos
Simulator.Screen.Recording.-.iPhone.17.-.2026-05-27.at.01.08.59.mov
📝 Checklist