Remove FXIOS-16009 Dead "upgrade" onboarding config + retire strings#34202
Merged
Conversation
The "What's New" upgrade flow was retired in FXIOS-15164, leaving its Nimbus config and strings dead. - Remove the two `onboarding-type: upgrade` cards (update-welcome, update-sign-to-sync) from onboardingFrameworkFeature.yaml; FxNimbus regenerates without them. - Retire the orphaned Upgrade.* strings into OldStrings.v153 (keys, values and comments preserved) per the string-removal convention. - Add a TODO at FirefoxAccountSignInViewController for FXIOS-16035 (remove OnboardingNotificationCardHelper + legacy NimbusOnboardingFeatureLayer). OnboardingType.upgrade enum is kept (still used by getOnboardingModel signatures and tests).
✍️ Strings UpdatedDetected changes in 🧹 Tidy commitJust 3 file(s) touched. Thanks for keeping it clean and review-friendly! 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 ✅ New file code coverageNo new file detected so code coverage gate wasn't ran. ✅ Existing file code coverageNo modified file had significant enough changes for the coverage gate to run. Client.app: Coverage: 41.59
Generated by 🚫 Danger Swift against 3db1a1d |
adudenamedruby
approved these changes
Jun 10, 2026
Contributor
|
🚀 PR merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
The "What's New" upgrade flow was retired in FXIOS-15164, leaving its Nimbus config and strings dead.
onboarding-type: upgradecards (update-welcome, update-sign-to-sync) from onboardingFrameworkFeature.yaml; FxNimbus regenerates without them.OnboardingType.upgrade enum is kept (still used by getOnboardingModel signatures and tests).
🎥 Demos
Demo
📝 Checklist