Bugfix MTE-5449 Option to ensure element to be in the view before taking action#34217
Draft
clarmso wants to merge 1 commit into
Draft
Bugfix MTE-5449 Option to ensure element to be in the view before taking action#34217clarmso wants to merge 1 commit into
clarmso wants to merge 1 commit into
Conversation
…tion Localized Settings rows can be pushed off-screen (present in the accessibility tree but not hittable), so MappaMundi taps fail and testSettings aborts, dropping the remaining screenshots. Pass MappaMundi's opt-in scrollIntoViewWithin on the Settings navigation taps so the target row is scrolled into view before tapping, and make forEachScreen fall back to swiping the table (with a no-progress guard) when a cell is offscreen. Depends on the MappaMundi scrollIntoViewWithin addition. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
clarmso
added
the
Do Not Merge ⛔️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
💡 Description
Important: Must be used together with updated MappaMundi: mozilla-mobile/MappaMundi#24. This change would NOT compile without it.
Some non Latin locales (including km, my, ru, ur, ab, bg) fail to have all settings L10n screenshots available. The L10n test
testSettingsattempts to tap on the menu item that's outside of the view. While this approach works in en-US, fr, es etc, but this approach does not work consistently mainly for Cyrillic character based locales.Summary of before and after the change. After the change, I get all
testSettingsscreenshots for 6 out of 7 problematic locales.I have run all smoke tests and all full functional tests. No new test failures have been introduced.
Open issue
bglocale still has issues navigating the settings menu.🎥 Demos
testSettingsinen-USlocale:https://github.com/user-attachments/assets/da2da999-b490-4c20-b30e-0e28621ab771
Demo
📝 Checklist