feat: bug 2055645: add support for direct git tags in landoscript payloads (BREAKING CHANGE)#238
Open
bhearsum wants to merge 1 commit into
Open
Conversation
…loads (BREAKING CHANGE) Note that this gets rid of the automatic lookup of revision and requires it to be present in the `worker` action instead. This is not _strictly_ necessary (we could, theoretically, stuff the git revision into parameters and have the payload builder look it up), but IMO the payload builders should avoid digging into parameters whenever possible in the first place. This makes this work a breaking change, and will require adjustments on the Gecko side to provide a git or hg revision, and the `hg_repo_url` when appropriate. See mozilla-releng/scriptworker-scripts#1491 for the landoscript side of this, which is required before this is merged.
Contributor
Author
|
https://phabricator.services.mozilla.com/D312774 is the gecko change I'm planning that's associated with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this gets rid of the automatic lookup of revision and requires it to be present in the
workeraction instead. This is not strictly necessary (we could, theoretically, stuff the git revision into parameters and have the payload builder look it up), but IMO the payload builders should avoid digging into parameters whenever possible in the first place. This makes this work a breaking change, and will require adjustments on the Gecko side to provide a git or hg revision, and thehg_repo_urlwhen appropriate.See mozilla-releng/scriptworker-scripts#1491 for the landoscript side of this, which is required before this is merged.