Skip to content

Use in-memory history in the blog-utils lib#14251

Merged
willdurand merged 1 commit into
masterfrom
in-memory
Jun 22, 2026
Merged

Use in-memory history in the blog-utils lib#14251
willdurand merged 1 commit into
masterfrom
in-memory

Conversation

@willdurand

Copy link
Copy Markdown
Member

This fixes a regression introduced in #13638

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.13%. Comparing base (8375884) to head (3b5d38f).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #14251   +/-   ##
=======================================
  Coverage   98.12%   98.13%           
=======================================
  Files         266      266           
  Lines       10648    10648           
  Branches     3287     3287           
=======================================
+ Hits        10448    10449    +1     
+ Misses        187      186    -1     
  Partials       13       13           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@willdurand willdurand requested a review from diox June 22, 2026 11:35

@diox diox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add a test for this with some mock in tests/unit/blog-utils/test_index.js ? Replicating the failure we had with building addons-blog without that patch (which does seem to fix the issue)

@willdurand

Copy link
Copy Markdown
Member Author

Could add a test for this with some mock in tests/unit/blog-utils/test_index.js ? Replicating the failure we had with building addons-blog without that patch (which does seem to fix the issue)

Yeah, good call obviously. Added, thanks!

@willdurand willdurand requested a review from diox June 22, 2026 12:30
@willdurand willdurand merged commit 6ff71eb into master Jun 22, 2026
9 checks passed
@willdurand willdurand deleted the in-memory branch June 22, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants