Skip to content

test(functional): disable flaky vpn integration spec via test.fixme #20606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbudhram merged 1 commit into from
May 15, 2026
Merged

test(functional): disable flaky vpn integration spec via test.fixme #20606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 37 additions & 36 deletions packages/functional-tests/tests/misc/vpnIntegration.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,40 +10,41 @@ import {
} from '../../lib/query-params';

test.describe('vpn integration', () => {
test('authorization flow - user already signed into Firefox', async ({
syncOAuthBrowserPages: { page, signin },
testAccountTracker,
}) => {
const { email, password } = await testAccountTracker.signUp();

// First, sign into Sync with Fenix (Android) client ID
await signin.goto('/authorization', syncMobileOAuthFenixQueryParams);
await signin.fillOutEmailFirstForm(email);
await signin.fillOutPasswordForm(password);

// Wait for Sync sign-in to complete, then clear events for the
// VPN scope check later in the test
await signin.checkWebChannelMessage(FirefoxCommand.OAuthLogin);
await signin.clearWebChannelEvents();

// Now navigate to VPN authorization — user is already signed into Firefox
await signin.goto('/authorization', vpnMobileOAuthQueryParams);

// User is already signed in — cached signin view, no password required
await expect(signin.cachedSigninHeading).toBeVisible();
await expect(page.getByText(email)).toBeVisible();

await signin.signInButton.click();

// Verify fxaOAuthLogin was sent with VPN scopes
await signin.checkWebChannelMessageScopes(
FirefoxCommand.OAuthLogin,
'https://identity.mozilla.com/apps/vpn'
);

// Verify services data includes vpn
await signin.checkWebChannelMessageServices(FirefoxCommand.Login, {
vpn: {},
});
});
// Disabled while we investigate the flaky cached-signin -> WebChannel race.
test.fixme(
'authorization flow - user already signed into Firefox',
async ({ syncOAuthBrowserPages: { page, signin }, testAccountTracker }) => {
const { email, password } = await testAccountTracker.signUp();

// First, sign into Sync with Fenix (Android) client ID
await signin.goto('/authorization', syncMobileOAuthFenixQueryParams);
await signin.fillOutEmailFirstForm(email);
await signin.fillOutPasswordForm(password);

// Wait for Sync sign-in to complete, then clear events for the
// VPN scope check later in the test
await signin.checkWebChannelMessage(FirefoxCommand.OAuthLogin);
await signin.clearWebChannelEvents();

// Now navigate to VPN authorization — user is already signed into Firefox
await signin.goto('/authorization', vpnMobileOAuthQueryParams);

// User is already signed in — cached signin view, no password required
await expect(signin.cachedSigninHeading).toBeVisible();
await expect(page.getByText(email)).toBeVisible();

await signin.signInButton.click();

// Verify fxaOAuthLogin was sent with VPN scopes
await signin.checkWebChannelMessageScopes(
FirefoxCommand.OAuthLogin,
'https://identity.mozilla.com/apps/vpn'
);

// Verify services data includes vpn
await signin.checkWebChannelMessageServices(FirefoxCommand.Login, {
vpn: {},
});
}
);
});