Conversation
xlisachan
force-pushed
the
PAY-3633
branch
13 times, most recently
from
July 13, 2026 17:48
fd2df0b to
84f960f
Compare
Because:
- react-hook-form v6 does not support React 19, blocking the planned upgrade
- v6 is unmaintained and has known issues with formState reactivity
This commit:
- Bumps react-hook-form from ^6.15.8 to ^7.54.0
- Adds `registration` prop to InputText/InputPassword for v7's register() API
- Migrates all 30+ form components from inputRef={register({...})} to registration={register('fieldName', {...})}
- Updates type interfaces from UseFormMethods to UseFormReturn
- Moves errors from top-level useForm destructure to formState.errors
- Fixes InputPhoneNumber to use setValue with shouldDirty/shouldValidate (v7 no longer auto-tracks dirty state via setValue)
- Updates tests for v7's async formState updates (userEvent over fireEvent, waitFor for formState assertions, VerifiedSessionGuard mock)
…y on test helpers
…or React 19 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
registrationprop to InputText/InputPassword for v7's register() APIIssue that this pull request solves
Closes: PAY-3633
Checklist
Put an
xin the boxes that apply