ci(functional-tests): reserve node 0 for serialized phone tests#20876
Open
nshirley wants to merge 1 commit into
Open
ci(functional-tests): reserve node 0 for serialized phone tests#20876nshirley wants to merge 1 commit into
nshirley wants to merge 1 commit into
Conversation
nshirley
force-pushed
the
fxa-functional-tests-reserve-phone-node
branch
from
July 15, 2026 20:22
c558272 to
fcf91df
Compare
nshirley
marked this pull request as ready for review
July 15, 2026 21:06
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CircleCI Playwright functional-test splitting so that when #phone tests are run serially on node 0, node 0 is removed from the timings-based split and the remaining nodes pick up the redistributed workload.
Changes:
- Skip running split Playwright tests on node 0 when
#phonetests are excluded and the job is running with parallelism > 1. - Redistribute the CircleCI timing split across nodes 1..N by shifting
--total/--indexdown by one. - Clarify the relationship between serialized phone tests and the split (comment update).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Because: - Node 0 was doing double duty: running the serialized #phone tests AND receiving its share of the timings-based split, making it the long pole that gated the whole functional-test job. This commit: - Makes run-playwright-tests reserve node 0 for the serialized #phone tests whenever #phone is grep-inverted out of the split and there is more than one node. Node 0 then skips the split (its phone tests already ran) and the split is redistributed across the remaining nodes via --total/--index shifted down by one. - Keys the behavior off the existing grep_invert: '#phone' signal rather than a separate flag, so payments and single-node smoke jobs (which run no phone tests) keep the full split. - Uses exit 0 (not step halt) so node 0 still stores/uploads its phone-test artifacts.
nshirley
force-pushed
the
fxa-functional-tests-reserve-phone-node
branch
from
July 15, 2026 21:49
c590496 to
89dc155
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
run-playwright-testsreserve node 0 for the serialized #phone tests whenever #phone is grep-inverted out of the split and there is more than one node. Node 0 then skips the split (its phone tests already ran) and the split is redistributed across the remaining nodes via--total/--indexshifted down by one.grep_invert: '#phone'signal rather than a separate flag, so payments and single-node smoke jobs (which run no phone tests) keep the full split unchanged.exit 0(not step halt) so node 0 still stores/uploads its phone-test artifacts.Closes: (issue number)
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.