fix(payments-next): [f010] prompt=none failure redirects to unvalidated callback-url cookie#20879
Open
elizabeth-ilina wants to merge 1 commit into
Conversation
…ed callback-url cookie Because: * The prompt=none login_required branch and the auth error page redirected to the authjs.callback-url cookie without validation, bypassing NextAuth's redirect allow-list. A cookie tossed from a sibling *.firefox.com subdomain could force an open redirect to an attacker-controlled URL. This commit: * Adds a shared getSafeRedirectUrl helper that validates redirect origins against the NextAuth allow-list, and applies it in the callback route, the auth error page, and the existing redirect callback. Closes #[PAY-3803](https://mozilla-hub.atlassian.net/browse/PAY-3803)
elizabeth-ilina
marked this pull request as ready for review
July 16, 2026 10:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes #PAY-3803
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.