Skip to content

fix(dist): close piped stdin before waiting on the child #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oguzhanmeteozturk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(dist): close piped stdin before waiting on the child #2806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/bin/sccache-dist/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ impl CommandExt for Command {
.take()
.expect("Requested piped stdin but not present");
pipe(&mut stdin).context("Failed to pipe input to process")?;
// `process.stdin` was moved out by the `.take()` above, so
// `wait_with_output()` has no stdin left to close. Without this the write
// end stays open for the rest of the function and a child that reads to
// EOF never returns.
drop(stdin);
let output = process
.wait_with_output()
.context("Failed to wait for process to return")?;
Expand Down
Loading