dist: refuse to trim rlibs from crates that also emit a cdylib - #2839
Merged
sylvestre merged 1 commit intoSep 14, 2026
Merged
Conversation
mozilla#1159 only guards the staticlib case; a cdylib sibling is .so/.dylib/.dll/.wasm, so the rlib is trimmed and the job fails on the build server.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2839 +/- ##
==========================================
+ Coverage 73.80% 75.79% +1.98%
==========================================
Files 72 72
Lines 38050 39232 +1182
==========================================
+ Hits 28084 29737 +1653
+ Misses 9966 9495 -471 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #1158, for crate-type = ["cdylib", "rlib"]:
#1159 only refuses to trim next to a
.a. Any linkable sibling now blockstrimming, matched with and without the
libprefix (libfoo.so,foo.wasm).test_can_trim_this covers both.