Skip to content

Bug 2045215 - [Perfherder][Comment_0] Alerts reassigned to a different summary are included in comment 0 when filing a new bug #9772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidmiculit wants to merge 2 commits into
base: master
Choose a base branch
from
+21 −7
Open

Bug 2045215 - [Perfherder][Comment_0] Alerts reassigned to a different summary are included in comment 0 when filing a new bug #9772

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f51c461
fix: filter the textualSummary shown alerts
davidmiculit Aug 10, 2026
34e7824
refactor: use alertStatusMap for readability and move the filter logi…
davidmiculit Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions ui/perfherder/alerts/StatusDropdown.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import PropTypes from 'prop-types';
import { Dropdown, Col, Form } from 'react-bootstrap';
import template from 'lodash/template';
import templateSettings from 'lodash/templateSettings';
import { alertStatusMap } from '../perf-helpers/constants';

import {
getFilledBugSummary,
Expand Down Expand Up @@ -82,12 +83,21 @@ export default class StatusDropdown extends React.Component {
};
};

filterValidAlerts = () => {
const { filteredAlerts = [], alertSummary } = this.props;
return filteredAlerts.filter(
(alert) =>
alert.status === alertStatusMap.acknowledged ||
alert.status === alertStatusMap.untriaged ||
(alert.status === alertStatusMap.reassigned && alert.summary_id !== alertSummary.id),
);
};

fileBug = async (culpritId) => {
const {
alertSummary,
repoModel,
updateViewState,
filteredAlerts = [],
frameworks,
user,
} = this.props;
Expand All @@ -106,9 +116,11 @@ export default class StatusDropdown extends React.Component {
updateViewState,
);

const validAlerts = this.filterValidAlerts();

const textualSummary = new TextualSummary(
frameworks,
filteredAlerts,
validAlerts,
alertSummary,
null,
await browsertimeAlertsExtraData.enrichAndRetrieveAlerts(),
Expand Down Expand Up @@ -214,7 +226,6 @@ export default class StatusDropdown extends React.Component {
const {
alertSummary,
repoModel,
filteredAlerts = [],
frameworks,
updateViewState,
user,
Expand All @@ -234,9 +245,11 @@ export default class StatusDropdown extends React.Component {
updateViewState,
);

const validAlerts = this.filterValidAlerts();

const textualSummary = new TextualSummary(
frameworks,
filteredAlerts,
validAlerts,
alertSummary,
null,
await browsertimeAlertsExtraData.enrichAndRetrieveAlerts(),
Expand Down Expand Up @@ -268,7 +281,7 @@ export default class StatusDropdown extends React.Component {

// can't access the clipboardData on event unless it's done from react's
// onCopy, onCut or onPaste props so using this workaround
navigator.clipboard.writeText(commentText).then(() => {});
navigator.clipboard.writeText(commentText).then(() => { });
};

async getBugTemplate(framework, updateViewState) {
Expand Down Expand Up @@ -324,7 +337,6 @@ export default class StatusDropdown extends React.Component {
alertSummary,
repoModel,
updateViewState,
filteredAlerts = [],
frameworks,
user,
} = this.props;
Expand All @@ -346,9 +358,11 @@ export default class StatusDropdown extends React.Component {
return { failureStatus: 'Failed to retrieve bug template' };
}

const validAlerts = this.filterValidAlerts();

const textualSummary = new TextualSummary(
frameworks,
filteredAlerts,
validAlerts,
alertSummary,
null,
await browsertimeAlertsExtraData.enrichAndRetrieveAlerts(),
Expand Down