Skip to content

Fix BreakID build#826

Merged
msoos merged 3 commits into
masterfrom
breakid-fix
Jun 4, 2026
Merged

Fix BreakID build#826
msoos merged 3 commits into
masterfrom
breakid-fix

Conversation

@msoos

@msoos msoos commented Jun 3, 2026

Copy link
Copy Markdown
Owner

This should fix #825 and add breakid build to the build.yml

@msoos

msoos commented Jun 4, 2026

Copy link
Copy Markdown
Owner Author

@copilot review please

Copilot AI commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@copilot review please

Found one issue: src/CMakeLists.txt line 190 hardcoded breakid instead of using ${BREAKID_LIBRARIES}, making the careful dual-path logic in the parent CMakeLists.txt pointless for the find_package case. Fixed in commit that just pushed.

The rest looks correct to me - the FetchContent / find_package gating, the include path change (breakid.hpp instead of breakid/breakid.hpp), and the API rename (get_version_sha1) all align with the upstream BreakID library.

Copilot finished work on behalf of msoos June 4, 2026 12:56
@msoos msoos merged commit 5ffd651 into master Jun 4, 2026
16 checks passed
@msoos msoos deleted the breakid-fix branch June 4, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breakid function name change

2 participants