Skip to content

add function to not use up all ingredients (reserve slot for item-type) #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IIIullaIII wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add function to not use up all ingredients (reserve slot for item-type) #189

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
46c95f3
add function
IIIullaIII Feb 20, 2026
a08c5e2
Correction
IIIullaIII Feb 23, 2026
922749c
group consuption
IIIullaIII Feb 23, 2026
4f6024d
Update autocrafter.lua
IIIullaIII Feb 23, 2026
7c1db33
Update autocrafter.lua
IIIullaIII Mar 1, 2026
3ba96c6
comment
IIIullaIII Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 56 additions & 15 deletions autocrafter.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ local function has_room_for_output(list_output, index_output)
return true
end

local function autocraft(inventory, craft)
local function autocraft(inventory, craft,pos)

@SwissalpS SwissalpS Feb 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space

if not craft then return false end

-- check if output and all replacements fit in dst
Expand All @@ -223,9 +223,17 @@ local function autocraft(inventory, craft)
-- check if we have enough material available
local inv_index = count_index(inventory:get_list("src"))
local consumption = calculate_consumption(inv_index, craft.consumption)

if not consumption then
return false
end
-- BLOCk (Riserve 1 item)

@SwissalpS SwissalpS Feb 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for all-caps, parenthesis and "reserve" not "Riserve"

@SwissalpS SwissalpS Feb 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-- reserve 1 item is sufficient

@IIIullaIII IIIullaIII Feb 22, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sorry for mystacle i have bad english :-P and I didn't look at the comments in the file, I initially wrote them in Italian for personal use to test the mod

if core.get_meta(pos):get_int("reserve") == 1 then
for item, num in pairs(consumption) do
if (inv_index[item] or 0) <= num then return false end
end
end


-- consume material
for itemname, number in pairs(consumption) do
Expand Down Expand Up @@ -263,7 +271,7 @@ local function run_autocrafter(pos, elapsed)
end

for _ = 1, math.floor(elapsed / craft_time) do
local continue = autocraft(inventory, craft)
local continue = autocraft(inventory, craft,pos)

@SwissalpS SwissalpS Feb 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space

@IIIullaIII IIIullaIII Mar 1, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

if not continue then return false end
end
return true
Expand Down Expand Up @@ -344,10 +352,17 @@ local function on_output_change(pos, inventory, stack)
end

-- returns false if we shouldn't bother attempting to start the timer again
-- after this

local function update_meta(meta, enabled)
local state = enabled and "on" or "off"
meta:set_int("enabled", enabled and 1 or 0)

-- Reserve State
local res_state = meta:get_int("reserve") == 1
local res_icon = res_state and "pipeworks_button_on.png" or "pipeworks_button_off.png"
local res_status_txt = res_state and S("RESERVE: ON") or S("RESERVE: OFF")

@SwissalpS SwissalpS Feb 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you feel we need all-caps status text?

@IIIullaIII IIIullaIII Feb 22, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary, it was just for aesthetics

@IIIullaIII IIIullaIII Mar 1, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

local res_tooltip = res_status_txt .. "\n" .. S("Keep 1 item in slot to prevent other items from filling it.")

local list_backgrounds = ""
if core.get_modpath("i3") or core.get_modpath("mcl_formspec") then
list_backgrounds = "style_type[box;colors=#666]"
Expand All @@ -370,6 +385,7 @@ local function update_meta(meta, enabled)
end
end
end

local size = "10.2,14"
local fs =
"formspec_version[2]" ..
Expand All @@ -379,8 +395,11 @@ local function update_meta(meta, enabled)
"list[context;recipe;0.22,0.22;3,3;]" ..
"image[4,1.45;1,1;[combine:16x16^[noalpha^[colorize:#141318:255]" ..
"list[context;output;4,1.45;1,1;]" ..
"image_button[4,2.6;1,0.6;pipeworks_button_" .. state .. ".png;" ..
state .. ";;;false;pipeworks_button_interm.png]" ..
"image_button[4.1,2.6;0.8,0.5;pipeworks_button_" .. state .. ".png;" .. state .. ";;;false;pipeworks_button_interm.png]" ..
"image_button[4.1,3.1;0.8,0.5;" .. res_icon .. ";btn_reserve;;;false;pipeworks_button_interm.png]" ..
"style[label_res;font_size=12]" ..
"label[3.6,3.95;" .. res_status_txt .. "]" ..
"tooltip[btn_reserve;" .. res_tooltip .. "]" ..
"list[context;dst;5.28,0.22;4,3;]" ..
"list[context;src;0.22,5;8,3;]" ..
pipeworks.fs_helpers.get_inv(9) ..
Expand All @@ -389,31 +408,37 @@ local function update_meta(meta, enabled)
"listring[current_player;main]" ..
"listring[context;dst]" ..
"listring[current_player;main]"

if core.get_modpath("digilines") then
fs = fs .. "field[0.22,4.1;4.5,0.75;channel;" .. S("Channel") ..
";${channel}]" ..
"button[5,4.1;2,0.75;set_channel;" .. S("Set") .. "]" ..
"button_exit[7.2,4.1;2,0.75;close;" .. S("Close") .. "]"

fs = fs .. "field[0.22,4.1;4.0,0.5;channel;" .. S("Channel") .. ";${channel}]" ..
"button[4.5,4.1;1.2,0.5;set_channel;" .. S("Set") .. "]" ..
"button_exit[6.0,4.1;1.5,0.5;close;" .. S("Close") .. "]"
end
meta:set_string("formspec", fs)

-- toggling the button doesn't quite call for running a recipe change check
-- so instead we run a minimal version for infotext setting only
-- this might be more written code, but actually executes less
local output = meta:get_inventory():get_stack("output", 1)
if output:is_empty() then -- doesn't matter if paused or not
local output_stack = meta:get_inventory():get_stack("output", 1)
if output_stack:is_empty() then
meta:set_string("infotext", S("unconfigured Autocrafter"))
return false
end

local description, name = get_item_info(output)
local description, name = get_item_info(output_stack)
local infotext = enabled and S("'@1' Autocrafter (@2)", description, name)
or S("paused '@1' Autocrafter", description)

meta:set_string("infotext", infotext)
return enabled
end


@SwissalpS SwissalpS Feb 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are all these empty lines for? If I'm not mistaken, pipeworks doesn't usually use this kind of formatting. I'd rather have the deleted comments back ;)

@IIIullaIII IIIullaIII Feb 22, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize again and yes I deleted my comments in Italian that I used for testing and maybe I deleted a few too many comments too








-- 1st version of the autocrafter had actual items in the crafting grid
-- the 2nd replaced these with virtual items, dropped the content on update and
-- set "virtual_items" to string "1"
Expand Down Expand Up @@ -484,6 +509,8 @@ core.register_node("pipeworks:autocrafter", {
inv:set_size("recipe", 3 * 3)
inv:set_size("dst", 4 * 3)
inv:set_size("output", 1)
meta:set_int("reserve", 0)

@SwissalpS SwissalpS Feb 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check indentation here.

@IIIullaIII IIIullaIII Mar 1, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


update_meta(meta, false)
end,
on_receive_fields = function(pos, formname, fields, sender)
Expand All @@ -493,6 +520,8 @@ core.register_node("pipeworks:autocrafter", {
return
end
local meta = core.get_meta(pos)

-- Machine on/off management
if fields.on then
update_meta(meta, false)
core.get_node_timer(pos):stop()
Expand All @@ -501,10 +530,22 @@ core.register_node("pipeworks:autocrafter", {
start_crafter(pos)
end
end

-- Channel Management (if present)
if fields.channel then
meta:set_string("channel", fields.channel)
end

--new: Gestion Button Reserve
Comment thread
SwissalpS marked this conversation as resolved.
Outdated
if fields.btn_reserve then
local current_res = meta:get_int("reserve")
local new_res = (current_res == 1 and 0 or 1)
meta:set_int("reserve", new_res)
-- Aggiorna l'interfaccia per mostrare il cambio colore
Comment thread
SwissalpS marked this conversation as resolved.
Outdated
update_meta(meta, meta:get_int("enabled") == 1)
end
end,

can_dig = function(pos, player)
upgrade_autocrafter(pos)
local meta = core.get_meta(pos)
Expand Down
85 changes: 85 additions & 0 deletions locale/pipeworks.it.tr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
# textdomain: pipeworks

## generic interaction
Set=Imposta
Cancel=Annulla

## digilines interfacing
Channel=Canale

## init
Allow splitting incoming stacks from tubes=Permetti di dividere gli stack in entrata dai tubi

## autocrafter
Unknown item=Oggetto sconosciuto
unconfigured Autocrafter: unknown recipe=Autocrafter non configurato: ricetta sconosciuta
unconfigured Autocrafter=Autocrafter non configurato
'@1' Autocrafter (@2)=Autocrafter di '@1' (@2)
Save=Salva
paused '@1' Autocrafter=Autocrafter di '@1' in pausa
Autocrafter=Autocrafter
# NUOVE TRADUZIONI PER LA RISERVA:
RESERVE: ON=RISERVA: ON
RESERVE: OFF=RISERVA: OFF
Keep 1 item in slot to prevent other items from filling it.=Mantieni 1 pezzo nello slot per evitare che altri oggetti lo riempiano.

## devices
Pump/Intake Module=Modulo Pompa/Aspirazione
Valve=Valvola
Decorative grating=Grata decorativa
Spigot outlet=Rubinetto di scarico
Airtight Pipe entry/exit=Ingresso/Uscita tubo ermetico
Flow Sensor=Sensore di flusso
Flow sensor (on)=Sensore di flusso (acceso)
empty=vuoto
@1% full=@1% pieno
Expansion Tank (@1)=Serbatoio di espansione (@1)
Fluid Storage Tank (@1)=Serbatoio di stoccaggio liquidi (@1)
Fountainhead=Sorgente a fontana
Straight-only Pipe=Tubo solo dritto

## filter-injector
(slot #@1 next)=(slot #@1 successivo)
@1 Filter-Injector=Iniettore-Filtro @1
Sequence slots by Priority=Sequenza slot per priorità
Sequence slots Randomly=Sequenza slot casuale
Sequence slots by Rotation=Sequenza slot per rotazione
Exact match - off=Corrispondenza esatta - OFF
Exact match - on=Corrispondenza esatta - ON
Prefer item types:=Preferisci tipi di oggetto:
Itemwise=Per oggetto
Stackwise=Per stack
Digiline=Digiline

## routing tubes
Pneumatic tube segment=Segmento di tubo pneumatico
Broken Tube=Tubo rotto
High Priority Tube Segment=Segmento di tubo ad alta priorità
Accelerating Pneumatic Tube Segment=Segmento di tubo pneumatico acceleratore
Crossing Pneumatic Tube Segment=Segmento di tubo pneumatico a incrocio
One way tube=Tubo a senso unico

## sorting tubes
Sorting Pneumatic Tube Segment=Segmento di tubo pneumatico di smistamento
Sorting pneumatic tube=Tubo pneumatico di smistamento

## teleport tube
Receive=Ricevi
Channels are public by default=I canali sono pubblici per impostazione predefinita
Use <player>:<channel> for fully private channels=Usa <giocatore>:<canale> per canali privati
Teleporting Pneumatic Tube Segment=Segmento di tubo pneumatico di teletrasporto
Teleporting Tube=Tubo di teletrasporto
Unconfigured Teleportation Tube=Tubo di teletrasporto non configurato

## trashcan
Trash Can=Cestino dei rifiuti

## vacuum tubes
Radius=Raggio
Vacuuming Pneumatic Tube Segment=Segmento di tubo pneumatico aspirante
Adjustable Vacuuming Tube=Tubo aspirante regolabile

## wielder
Node Breaker=Rompiblocco
Deployer=Posizionatore
Dispenser=Dispenser
6 changes: 5 additions & 1 deletion locale/template.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ unconfigured Autocrafter=
Save=
paused '@1' Autocrafter=
Autocrafter=
# Reserve button:
RESERVE: ON=
RESERVE: OFF=

Keep 1 item in slot to prevent other items from filling it.=

## compat-furnaces
Allow splitting incoming material (not fuel) stacks from tubes=
Expand Down Expand Up @@ -64,7 +69,6 @@ Auto-Tap=
Pipe Segment=
Pipe Segment (legacy)=


## routing tubes
Pneumatic tube segment=
Broken Tube=
Expand Down