JSON config > + direction_headsign_ignore_trip_headsign... #lio#74
Conversation
mmathieum
changed the title
direction_headsign_ignore_trip_headsign.. #lioJSON config > + direction_headsign_ignore_trip_headsign... #lio
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new configuration option directionHeadsignIgnoreTripHeadsign and updates the cleanDirectionHeadsign method signature to accept a fromTripHeadSign boolean flag, allowing the parser to ignore trip headsigns when cleaning direction headsigns. The feedback highlights a consistent typo in the newly introduced variable and parameter name fromTripHeaSign (missing 'd') across DefaultAgencyTools.java and GAgencyTools.java, suggesting it be renamed to fromTripHeadSign.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new configuration option direction_headsign_ignore_trip_headsign to ignore trip headsigns when cleaning direction headsigns, updating the cleanDirectionHeadsign method signature and its usages across the codebase. The feedback suggests improving the Java implementation of cleanDirectionHeadsign by using a guard clause to avoid parameter reassignment and unnecessary processing. Additionally, the feedback recommends reverting several Kotlin functions in RouteConfig.kt back to expression bodies to adhere to the Kotlin Style Guide and maintain consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…nore_trip_headsign`... #lio mtransitapps/parser#74
1 participant
No description provided.