Skip to content

JSON config > + to_lower_upper_case_words_min_pct#75

Merged
mmathieum merged 1 commit into
masterfrom
mm/custom_LC_pct
Jul 3, 2026
Merged

JSON config > + to_lower_upper_case_words_min_pct#75
mmathieum merged 1 commit into
masterfrom
mm/custom_LC_pct

Conversation

@mmathieum

Copy link
Copy Markdown
Member

@mmathieum mmathieum self-assigned this Jul 3, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new configuration option toLowerUpperCaseWordsMinPct in AgencyConfig and integrates it into DefaultAgencyTools for route, trip headsign, and stop name cleaning. The feedback suggests changing the visibility of the new helper method lowerUCWordsMinPct() from private to public or protected to allow subclasses to override it, along with adding @SuppressWarnings("WeakerAccess").

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/java/org/mtransit/parser/DefaultAgencyTools.java
@mmathieum mmathieum merged commit 4d6fc81 into master Jul 3, 2026
4 checks passed
@mmathieum mmathieum deleted the mm/custom_LC_pct branch July 3, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant