fix(deps): bump cogito to fix MCP image-content panic (#10101)#10105
Open
Dennisadira wants to merge 1 commit into
Open
fix(deps): bump cogito to fix MCP image-content panic (#10101)#10105Dennisadira wants to merge 1 commit into
Dennisadira wants to merge 1 commit into
Conversation
Owner
|
@Dennisadira please rebase, lots of code which is not part of this PR shows up |
Dennisadira
force-pushed
the
fix/mcp-image-content-panic
branch
from
9cf3bd1 to
a65eb0b
Compare
Contributor
Author
|
Rebased onto current master — the branch now has a single commit touching only |
Bumps github.com/mudler/cogito from v0.9.5-0.20260315222927-63abdec7189b to v0.9.5-0.20260531081147-2c13b6ac29cf The new revision contains mudler/cogito#50 which replaces the hard *mcp.TextContent type assertion in mcpTool.Execute with a type switch. Any MCP tool that returns image, audio, resource-link, or embedded-resource content previously caused: panic: interface conversion: mcp.Content is *mcp.ImageContent, not *mcp.TextContent bringing down the entire host process. The new code summarises non-text blocks with a descriptive marker so the model receives something useful without crashing. Closes mudler#10101 Assisted-by: Claude Sonnet 4.6 [claude-code] Signed-off-by: Adira Denis Muhando <dennisadira@gmail.com>
Dennisadira
force-pushed
the
fix/mcp-image-content-panic
branch
from
a65eb0b to
615d649
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10101 — the API container crashes with a Go panic whenever an MCP tool returns non-text content (images, audio, resources):
The panic happens on an agent goroutine with no
recover, which takes the whole process down.Root cause:
mcpTool.Executein cogito unconditionally asserted everymcp.Contentitem to*mcp.TextContent. Any tool returning image/audio/resource content (e.g. theget_map_imagetool in osmmcp, NASA MCP image tools) triggers the panic.Fix: mudler/cogito#50 replaces the hard assertion with a type switch. Non-text blocks are summarised with descriptive markers (
[image content (image/png), N bytes]etc.) so the model receives something useful instead of crashing.This PR bumps
github.com/mudler/cogitofromv0.9.5-0.20260315222927-63abdec7189btov0.9.5-0.20260531081147-2c13b6ac29cf(the tip of thefix/mcp-image-content-panicbranch in cogito, which is the revision from mudler/cogito#50).Test plan
go build github.com/mudler/cogitoclean on the new pseudo-versiongo mod tidyproduces a clean go.sum🤖 Generated with Claude Code