[styled-engine] Prevent enableCssLayer styles from being overridden by unlayered styles#48603
Open
Janpot wants to merge 3 commits into
Open
[styled-engine] Prevent enableCssLayer styles from being overridden by unlayered styles#48603Janpot wants to merge 3 commits into
Janpot wants to merge 3 commits into
Conversation
Deploy previewhttps://deploy-preview-48603--material-ui.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
Janpot
force-pushed
the
styled-engine/dedicated-cache-key
branch
2 times, most recently
from
8ecd8ba to
99c77f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This was showing up in the visual regression tests after #48575, depending on when the
injectFirstfixture runs.When
enableCssLayeris set,StyledEngineProviderwraps MUI's styles in@layer muibut keeps emotion's default cache keycss- the same key used by the default andinjectFirstcaches, which insert unlayered. Since the generated class name is${key}-${hash}, the same style produces the same class name in both the layered and the unlayered caches. An unlayered rule outranks every cascade layer, so whenever a style ends up inserted both unlayered (default /injectFirst) and layered, the unlayered copy silently overrides MUI's own layered style.