Skip to content

[InitColorSchemeScript] Server-render in tests for React 19.3 #48604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Janpot wants to merge 1 commit into
base: master
Choose a base branch
from
+25 −18
Open

[InitColorSchemeScript] Server-render in tests for React 19.3 #48604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/mui-material/src/InitColorSchemeScript/InitColorSchemeScript.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import { createRenderer } from '@mui/internal-test-utils';
import InitColorSchemeScript from '@mui/material/InitColorSchemeScript';

describe('InitColorSchemeScript', () => {
const { render } = createRenderer();
const { renderToString } = createRenderer();

it('should render as expected', () => {
const { container } = render(<InitColorSchemeScript />);
const { container } = renderToString(<InitColorSchemeScript />);
expect(container.firstChild).to.have.tagName('script');
});
});
39 changes: 23 additions & 16 deletions packages/mui-system/src/InitColorSchemeScript/InitColorSchemeScript.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ import {
} from './InitColorSchemeScript';

describe('InitColorSchemeScript', () => {
const { render } = createRenderer();
// `InitColorSchemeScript` is only ever rendered on the server (Next.js `_document` or the App
// Router root layout), so render it to a string here. A client mount of a `<script>` triggers a
// React warning (and is a non-executing no-op) starting with React 19.3.
const { renderToString } = createRenderer();
let originalMatchmedia;
let storage = {};
const createMatchMedia = (matches) => () => ({
Expand Down Expand Up @@ -41,7 +44,7 @@ describe('InitColorSchemeScript', () => {
storage[DEFAULT_MODE_STORAGE_KEY] = 'light';
storage[`${DEFAULT_COLOR_SCHEME_STORAGE_KEY}-light`] = 'foo';

const { container } = render(<InitColorSchemeScript />);
const { container } = renderToString(<InitColorSchemeScript />);
eval(container.firstChild.textContent);
expect(document.documentElement.getAttribute(DEFAULT_ATTRIBUTE)).to.equal('foo');
});
Expand All @@ -51,7 +54,7 @@ describe('InitColorSchemeScript', () => {
storage[`${DEFAULT_COLOR_SCHEME_STORAGE_KEY}-light`] = 'foo';
document.documentElement.classList.remove(...document.documentElement.classList);

const { container } = render(<InitColorSchemeScript attribute="class" />);
const { container } = renderToString(<InitColorSchemeScript attribute="class" />);
expect(container.firstChild.textContent.replace(/\s/g, '')).not.to.include(
"setAttribute('.%s',colorScheme)",
);
Expand All @@ -64,7 +67,7 @@ describe('InitColorSchemeScript', () => {
storage[DEFAULT_MODE_STORAGE_KEY] = 'light';
storage[`${DEFAULT_COLOR_SCHEME_STORAGE_KEY}-light`] = 'foo';

const { container } = render(<InitColorSchemeScript attribute="data" />);
const { container } = renderToString(<InitColorSchemeScript attribute="data" />);
eval(container.firstChild.textContent);
expect(document.documentElement.getAttribute('data-foo')).to.equal('');
});
Expand All @@ -73,7 +76,7 @@ describe('InitColorSchemeScript', () => {
storage['mui-foo-mode'] = 'light';
storage[`mui-bar-color-scheme-light`] = 'flash';

const { container } = render(
const { container } = renderToString(
<InitColorSchemeScript
modeStorageKey="mui-foo-mode"
colorSchemeStorageKey="mui-bar-color-scheme"
Expand All @@ -89,12 +92,12 @@ describe('InitColorSchemeScript', () => {
storage[`${DEFAULT_COLOR_SCHEME_STORAGE_KEY}-light`] = 'foo';
storage[`${DEFAULT_COLOR_SCHEME_STORAGE_KEY}-dark`] = 'bar';

const { container, rerender } = render(<InitColorSchemeScript attribute=".mode-%s" />);
let { container } = renderToString(<InitColorSchemeScript attribute=".mode-%s" />);
eval(container.firstChild.textContent);
expect(document.documentElement.classList.value).to.equal('mode-foo');

storage[DEFAULT_MODE_STORAGE_KEY] = 'dark';
rerender(<InitColorSchemeScript attribute=".mode-%s" />);
({ container } = renderToString(<InitColorSchemeScript attribute=".mode-%s" />));
eval(container.firstChild.textContent);
expect(document.documentElement.classList.value).to.equal('mode-bar');

Expand All @@ -106,13 +109,13 @@ describe('InitColorSchemeScript', () => {
storage[`${DEFAULT_COLOR_SCHEME_STORAGE_KEY}-light`] = 'foo';
storage[`${DEFAULT_COLOR_SCHEME_STORAGE_KEY}-dark`] = 'bar';

const { container, rerender } = render(<InitColorSchemeScript attribute="[data-mode-%s]" />);
let { container } = renderToString(<InitColorSchemeScript attribute="[data-mode-%s]" />);
eval(container.firstChild.textContent);
expect(document.documentElement.getAttribute('data-mode-foo')).to.equal('');
expect(document.documentElement.getAttribute('data-mode-bar')).to.equal(null);

storage[DEFAULT_MODE_STORAGE_KEY] = 'dark';
rerender(<InitColorSchemeScript attribute="[data-mode-%s]" />);
({ container } = renderToString(<InitColorSchemeScript attribute="[data-mode-%s]" />));
eval(container.firstChild.textContent);
expect(document.documentElement.getAttribute('data-mode-bar')).to.equal('');
expect(document.documentElement.getAttribute('data-mode-foo')).to.equal(null);
Expand All @@ -123,12 +126,12 @@ describe('InitColorSchemeScript', () => {
storage[`${DEFAULT_COLOR_SCHEME_STORAGE_KEY}-light`] = 'foo';
storage[`${DEFAULT_COLOR_SCHEME_STORAGE_KEY}-dark`] = 'bar';

const { container, rerender } = render(<InitColorSchemeScript attribute="[data-mode='%s']" />);
let { container } = renderToString(<InitColorSchemeScript attribute="[data-mode='%s']" />);
eval(container.firstChild.textContent);
expect(document.documentElement.getAttribute('data-mode')).to.equal('foo');

storage[DEFAULT_MODE_STORAGE_KEY] = 'dark';
rerender(<InitColorSchemeScript attribute="[data-mode='%s']" />);
({ container } = renderToString(<InitColorSchemeScript attribute="[data-mode='%s']" />));
eval(container.firstChild.textContent);
expect(document.documentElement.getAttribute('data-mode')).to.equal('bar');
});
Expand All @@ -137,7 +140,7 @@ describe('InitColorSchemeScript', () => {
storage[DEFAULT_MODE_STORAGE_KEY] = 'dark';
storage[`${DEFAULT_COLOR_SCHEME_STORAGE_KEY}-dark`] = 'bar';

const { container } = render(<InitColorSchemeScript />);
const { container } = renderToString(<InitColorSchemeScript />);
eval(container.firstChild.textContent);
expect(document.documentElement.getAttribute(DEFAULT_ATTRIBUTE)).to.equal('bar');
});
Expand All @@ -147,7 +150,7 @@ describe('InitColorSchemeScript', () => {
storage[`${DEFAULT_COLOR_SCHEME_STORAGE_KEY}-dark`] = 'dim';
window.matchMedia = createMatchMedia(true);

const { container } = render(<InitColorSchemeScript />);
const { container } = renderToString(<InitColorSchemeScript />);
eval(container.firstChild.textContent);
expect(document.documentElement.getAttribute(DEFAULT_ATTRIBUTE)).to.equal('dim');
});
Expand All @@ -157,7 +160,7 @@ describe('InitColorSchemeScript', () => {
storage[`${DEFAULT_COLOR_SCHEME_STORAGE_KEY}-light`] = 'bright';
window.matchMedia = createMatchMedia(false);

const { container } = render(<InitColorSchemeScript />);
const { container } = renderToString(<InitColorSchemeScript />);
eval(container.firstChild.textContent);
expect(document.documentElement.getAttribute(DEFAULT_ATTRIBUTE)).to.equal('bright');
});
Expand All @@ -166,15 +169,19 @@ describe('InitColorSchemeScript', () => {
it('should set dark color scheme to body, given prefers-color-scheme is `dark`', () => {
window.matchMedia = createMatchMedia(true);

const { container } = render(<InitColorSchemeScript defaultDarkColorScheme="trueDark" />);
const { container } = renderToString(
<InitColorSchemeScript defaultDarkColorScheme="trueDark" />,
);
eval(container.firstChild.textContent);
expect(document.documentElement.getAttribute(DEFAULT_ATTRIBUTE)).to.equal('trueDark');
});

it('should set light color scheme to body, given prefers-color-scheme is NOT `dark`', () => {
window.matchMedia = createMatchMedia(false);

const { container } = render(<InitColorSchemeScript defaultLightColorScheme="yellow" />);
const { container } = renderToString(
<InitColorSchemeScript defaultLightColorScheme="yellow" />,
);
eval(container.firstChild.textContent);
expect(document.documentElement.getAttribute(DEFAULT_ATTRIBUTE)).to.equal('yellow');
});
Expand Down
Loading