[material-ui] Keep CSS theme variables out of the default theme#48607
Draft
Janpot wants to merge 1 commit into
Draft
[material-ui] Keep CSS theme variables out of the default theme#48607Janpot wants to merge 1 commit into
Janpot wants to merge 1 commit into
Conversation
Deploy previewhttps://deploy-preview-48607--material-ui.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defaultThemeis built through the publiccreateTheme(), which statically imports bothcreateThemeNoVarsandcreateThemeWithVarsand selects one at runtime based on thecssVariablesoption. Because that dispatch is a runtime branch, bundlers can't tree-shake the unused CSS-variables path, so the wholecreateThemeWithVarsmachinery (and its helpers:createColorScheme,createGetSelector,excludeVariablesFromRoot,getOverlayAlpha,prepareTypographyVars) ends up in every component bundle that only needs the default fallback theme.createTheme()with no arguments is definitionally identical tocreateThemeNoVars()— the defaultcssVariables: falsepath returnscreateThemeNoVars(options), andcreateThemeNoVarsdoes not depend oncreateThemeWithVars. Importing it directly produces a byte-identical default theme while letting the dead CSS-vars code be dropped.The public
createThemeexport is untouched, so consumers who opt into CSS theme variables are unaffected.Bundle size impact
Measured with
test/bundle-size(gzip):@mui/material/Button@mui/material/Typography@mui/material/IconButton@mui/material/Checkbox@mui/material/Slider@mui/material/Switch@mui/material(barrel)@mui/material/styles#createTheme~4.7 kB gzip (~18 kB parsed) off essentially every component, while the
@mui/materialbarrel and the publiccreateThemeentry are unchanged.