[docs] update Tooltip "disabled elements" section#48623
Closed
mayank99 wants to merge 2 commits into
Closed
Conversation
1 task
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
mayank99
force-pushed
the
mayank/tooltip-disabled-docs
branch
from
021dc0a to
341f0f9
Compare
mayank99
commented
Jun 4, 2026
| <span> | ||
| <Button disabled>A Disabled Button</Button> | ||
| </span> | ||
| <Button disabled style={{ pointerEvents: 'auto' }}> |
Author
There was a problem hiding this comment.
This isn't working anymore. It was working when I last tested it in 9.0.1: https://stackblitz.com/edit/sjet9vpm?file=src%2FDemo.tsx.
This change from #48606 is the likely cause:
material-ui/packages/mui-material/src/Tooltip/Tooltip.js
Lines 359 to 362 in 41b68b8
Author
|
Folded into #48622 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The changes from this PR have been moved into #48622.
Original PR description:
This is a companion to #48622. The "Disabled elements" section of the Tooltip docs has been reworked to remove the wrapper
<span>recommendation. See #33182 (comment) for longer explanation.There are two annoying parts:
The default
pointer-events: noneneeds to be undone from Buttons (see related section in Button docs). I believe this should be addressed within ButtonBase in a separate PR.Keyboard accessibility (or lack thereof) is mentioned as a warning. This should be updated to recommend the
focusableWhenDisabledprop after [button] Enable buttons to remain focusable when disabled #48613 merges.I have followed (at least) the PR section of the contributing guide.