fix: make base32 decode case-insensitive#50
Merged
seetadev merged 1 commit intoJul 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36
Description
This pull request makes
Base32StringConvertercase-insensitive during decoding, which complies with the multibase specification and matches the behavior of the Go reference implementation (go-multibase).Previously, decoding a Base32 payload with mismatched case compared to its prefix encoding (e.g.
base32with an uppercase payloadbMZXW6, orbase32upperwith a lowercase payloadBmzxw6) would raise aValueErrorduring alphabet mapping.Changes Made
Base32StringConverter.decodeinmultibase/converters.pyto checkself.digits.islower()andself.digits.isupper(). It now normalizes the payload's case to match the alphabet before iterating over the bytes.test_decode_base32_case_insensitive) totests/test_multibase.pyto verify this behavior forbase32,base32upper,base32pad, andbase32hex.Verification
pytest tests/).make lintcatches no errors and runs completely successfully.