feat: add encoder_by_name factory function#54
Open
sumanjeet0012 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
Description
This pull request adds an
encoder_by_name()factory function, which enables creating anEncoderfrom a single-character prefix as well as the standard name, bringing the python implementation into alignment with thego-multibasereference implementation.Changes
encoder_by_name()inmultibase/multibase.pywhich inspects the given string and resolves it if it matches either a name or a prefix.encoder_by_namefrom__init__.py.encoder_by_namedemonstrating successful construction from prefix, name, and base256emoji, as well as proper exception handling for unsupported/invalid strings.