Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AndroidQF modules look for artifacts using patterns such as
*/packages.json. Directory input includes the acquisition directory in each path, but a ZIP can containpackages.jsonat its root. Those ZIP members were not matched, so modules returned no records even though the equivalent extracted directory worked.Allow the leading
*/to match an absent directory prefix, and normalize separators only for matching. Preserve original filenames and their order so archive reads still work and overlapping patterns do not duplicate results.Fixes #931.
Validation:
mypy --platform linuxpass.178ac52; they concern existing platform/environment behavior. The AndroidQF subset has 72 passing tests and one existing CRLF assertion failure.os.O_NOCTTYerror incommon/password.py; Linux-targeted checking passes.