Repository navigation
chore(deps): clear 28 of the 36 open Dependabot alerts - #722
Merged
Merged
Conversation
- Remove @codeceptjs/ui and the `start:gui` script that ran it. It is only used for the interactive CodeceptJS GUI, not by CI, and its latest release (1.3.8) still pins electron ^38, which carries 24 Dependabot alerts (fixed only in 41.10.6+). This also drops the Electron binary download from every e2e install. `npx @codeceptjs/ui` still works ad hoc. - Override basic-ftp to ^6.2.1 (GHSA-c475-qrg2-pj4r). It comes in via puppeteer -> @puppeteer/browsers -> proxy-agent -> pac-proxy-agent -> get-uri, whose latest release still asks for ^5. basic-ftp 6 only changes the default for separate transfer hosts; get-uri uses access, lastMod, list, downloadTo and close, which are unchanged. Signed-off-by: kurok <22548029+kurok@users.noreply.github.com>
Clears sprintf-js (GHSA-hp3w-g68c-fv3c, no patched release) from ilc and registry. It came in via babel-plugin-istanbul (ilc) and nyc (registry) -> @istanbuljs/load-nyc-config (1.1.0 is its latest release) -> js-yaml 3 -> argparse 1 -> sprintf-js. load-nyc-config only calls js-yaml's load(), and only for a YAML nyc config; js-yaml 4 keeps load() and depends on argparse 2, which does not use sprintf-js. Signed-off-by: kurok <22548029+kurok@users.noreply.github.com>
sqlite3 5 builds through node-gyp 8 -> make-fetch-happen 9 -> http-proxy-agent 4 -> @tootallnate/once 1.1.2 (GHSA-vpq2-c234-7xj6). sqlite3 6 uses node-gyp 12 instead, removing 89 packages from the lockfile. It requires Node.js >= 20.17; the registry already requires >= 22. The Alpine Docker image builds it, and the sqlite test suite passes with it. Signed-off-by: kurok <22548029+kurok@users.noreply.github.com>
Coverage ReportIlc/serverCommit SHA:8d1f47e3ecd3e417bcbfa157c563a577dad0ec5b Test coverage results 🧪File details
Ilc/clientCommit SHA:8d1f47e3ecd3e417bcbfa157c563a577dad0ec5b Test coverage results 🧪File details
RegistryCommit SHA:8d1f47e3ecd3e417bcbfa157c563a577dad0ec5b Test coverage results 🧪File details
|
m2broth
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #721. Master currently has 36 open Dependabot alerts (12 high, 19 medium, 5 low). This PR clears 28 of them with three small dependency changes. No application code changes.
@codeceptjs/ui(and itsstart:guiscript); overridebasic-ftpto^6.2.1electron+ 1basic-ftpjs-yamlto^4.1.1under@istanbuljs/load-nyc-configsprintf-jssqlite3^5.1.7→^6.0.1@tootallnate/onceLockfiles mostly shrink: −75 packages in e2e, −89 net in registry, −5 in ilc. The only version moves are the intended ones:
basic-ftp5.3.1 → 6.2.2,js-yaml3 → 4 (withargparse1 → 2), andsqlite35.1.7 → 6.0.1 (withnode-gyp8 → 12). Lockfiles were regenerated with npm 10.9.9 / Node 22 (same as CI and the Docker images) using--before=2026-10-08.Why each change is safe
@codeceptjs/uiis used only by the interactivenpm run start:gui, not by CI. Its latest release (1.3.8) still pinselectron ^38, which has 24 alerts, all fixed only in 41.10.6+. Removing it also stops every e2e install from downloading the Electron binary. Anyone who wants the GUI can still run it ad hoc withnpx @codeceptjs/ui.basic-ftp6 comes in throughpuppeteer → @puppeteer/browsers → proxy-agent → pac-proxy-agent → get-uri. Even the latestget-uristill asks for^5. The only breaking change in 6.0 is that separate FTP transfer hosts are refused by default (a security default).get-urionly callsaccess,lastMod,list,downloadToandclose, all unchanged.js-yaml4 for@istanbuljs/load-nyc-config(1.1.0 is its latest release): that package only callsjs-yaml'sload(), and only for a YAML nyc config.js-yaml4 keepsload()and depends onargparse2, which doesn't usesprintf-js(sprintf-jshas no patched release).sqlite36 replaces thenode-gyp 8 → make-fetch-happen 9 → http-proxy-agent 4 → @tootallnate/once 1build chain withnode-gyp12. It requires Node ≥ 20.17; the registry already requires ≥ 22.Verification
All of this ran in Docker, following this repo's CI steps:
npm ls @newrelic/native-metricscheck passes. 673 server tests pass with coverage (2 pending) and 657 client tests pass, the same counts as master.sqlite36.0.1 compiled, and the native module loads (SQLite 3.52.0).npm run test:cion sqlite3: 511 passing, 22 pending.npm ciworks, andcodeceptjs dry-runloads the config and lists all 42 tests in 12 suites. The full E2E run is left to CI.Not fixed here (8)
These need a major migration or a dismissal, not a dependency bump:
stream-json×3,braces×1codeceptjs3.7.9's optional@codeceptjs/detox-helper→detox/react-nativeextract-zip×2puppeteer24 →@puppeteer/browsers2 (no patched release)sprintf-js×1codeceptjs(no patched release)decode-uri-component×1query-string5, reached throughra-data-simple-rest3 andsrc/appRoutes/Edit.js(which imports it without declaring it)Edit.jscallsqueryString.parse(location.search), so the vulnerable decoder is reachable: do not dismiss. Fix: switch that line toURLSearchParamsand overridequery-stringto^9.5.1(follow-up)