Mnt: Block qt6 6.11.0, 6.11.1 due to dock widget and resizing bugs#9052
Conversation
Co-authored-by: Carlos Rodriguez <carlosmariorr90@hotmail.com> Co-authored-by: Carlos Mario Rodriguez Reza <52670744+carlosmariorr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9052 +/- ##
=======================================
Coverage 93.50% 93.51%
=======================================
Files 710 710
Lines 66408 66408
=======================================
+ Hits 62094 62100 +6
+ Misses 4314 4308 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
You need to edit the version_denylist files as well, otherwise the bad versions will come back in constraints. |
I wonder if that is changed behavior? Because I ran the bash script ( |
|
Also you didn't want to nuke 6.11.0 too? I think it's best since we know it has issues as well. |
I was waffling back and forth. Ultimately that's what @carlosmariorr and I opted for. I'm certainly open to it -- can you clarify what known issues it has? As far as I have personally tested, 6.11.0 works for our current main. I know we've both seen the Qt6 Jira board and that does imply some bugs though. Ultimately, I'm conflicted on it 🤷 Also, in practicality, I ended up debugging constantly on 6.11.0 to try to figure out differences between it and 6.11.1 today, without finding any issues |
|
version_denylist.txt does not need updated, see napari/docs#1043 |
|
Yup to you. I outlined the oracle reasoning in the zulip thread but the gist is: |
|
I've opted to also block 6.11.0 |
References and relevant issues
xref #9054
Zulip discussion: https://napari.zulipchat.com/#narrow/channel/215289-release/topic/0.2E7.2E1.20-.20pop.20out.20widget.20bug.20on.20Qt.206.2E11.2E1.20.28latest.29/with/602196289
Description
This blocks Qt 6.11.1 versions because of docking issues detailed in #9054. Carlos and I worked on this at today's community meeting. We blocked this Qt version for both pyside6 and pyqt6-qt6 (because pyqt6 is still just at 6.11.0) in pyproject.toml
Then we used the following:
tools/compile_constraints.sh pyside6tools/compile_constraints.sh pyqt6-qt6Update: I've opted to also block 6.11.0
I do think, in the case of critical functionality aka the GUI, we should probably err on the side of conservative. Especially because there's not like computational/speed benefits or somethign that we lose
Alternatively
Qt < 6.11<- the absolute safest pin, but I really don't like upper pins, they seem to be actively working on it.Qt !=6.11.0, !=6.11.1also more conservative, and maybe the safe play. But in all my time debugging Fix floating widgets and use custom title bar in all cases #8898 and today while debugging 6.11.0 never caused issues, and is the reason I haven't adopted it (or an upper pin)