Skip to content

CMR-11413: Update jackson core and move to parent - #2488

Open
jmaeng72 wants to merge 3 commits into
masterfrom
CMR-11413
Open

CMR-11413: Update jackson core and move to parent#2488
jmaeng72 wants to merge 3 commits into
masterfrom
CMR-11413

Conversation

@jmaeng72

@jmaeng72 jmaeng72 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Overview

What is the objective?

Update jackson-core dep version

What are the changes?

  • Update jackson-core dep version
  • Update cheshire version
  • Centralized jackson-core, jackson-databind, jackson-dataformat-cbor, jackson-dataformat-smile, cheshire to parent project level
  • Update access-control sys test to use flat string instead of a nested Clojure map, because of how new version of jackson-core and cheshire works with old clj-http

What areas of the application does this impact?

All

Required Checklist

  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors in changed files are corrected
  • I have commented my code, particularly in hard-to-understand areas
  • I have made changes to the documentation (if necessary)
  • My changes generate no new warnings

Additional Checklist

  • I have removed unnecessary/dead code and imports in files I have changed
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • reduced number of system state resets by updating fixtures. Ex) (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@jmaeng72 jmaeng72 self-assigned this Aug 25, 2026
@jmaeng72
jmaeng72 marked this pull request as draft August 25, 2026 17:57
@codecov-commenter

codecov-commenter commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.20%. Comparing base (c5cd748) to head (ab97804).

❗ There is a different number of reports uploaded between BASE (c5cd748) and HEAD (ab97804). Click for more details.

HEAD has 20 uploads less than BASE
Flag BASE (c5cd748) HEAD (ab97804)
24 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2488       +/-   ##
===========================================
- Coverage   57.96%   29.20%   -28.77%     
===========================================
  Files        1074     1014       -60     
  Lines       74707    71257     -3450     
  Branches     2193     1265      -928     
===========================================
- Hits        43307    20811    -22496     
- Misses      29354    49244    +19890     
+ Partials     2046     1202      -844     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmaeng72
jmaeng72 marked this pull request as ready for review August 31, 2026 20:48
{:group-permission {:0 query-map} :page_size 20}
(let [flat-query (into {}
(for [[k v] query-map]
[(str "group-permission[0][" (name k) "]") v]))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put this string key encoding into a helper and use it here and in generate-query-map-for-group-permissions

Comment thread project.clj
[lein-shell "0.5.0"]]
:managed-dependencies [[at.yawk.lz4/lz4-java "1.11.1"]
[cheshire "5.12.0"] ;; latest is 6.1.0
[cheshire "6.2.0"] ;; latest is 6.1.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update comment

cmr.elasticsearch.plugins.spatial.plugin]}
:dev {:dependencies [[criterium "0.4.4"]
[cheshire "5.12.0"]
[cheshire "6.2.0"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget the reason, but is parent-project not possible here?

@daniel-zamora daniel-zamora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nit picks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants