Conversation
jmaeng72
marked this pull request as draft
August 25, 2026 17:57
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #2488 +/- ##
===========================================
- Coverage 57.96% 29.20% -28.77%
===========================================
Files 1074 1014 -60
Lines 74707 71257 -3450
Branches 2193 1265 -928
===========================================
- Hits 43307 20811 -22496
- Misses 29354 49244 +19890
+ Partials 2046 1202 -844 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jmaeng72
marked this pull request as ready for review
August 31, 2026 20:48
jmaeng72
requested review from
daniel-zamora,
eereiter,
ibsenc,
jceaser and
zimzoom
August 31, 2026 20:49
| {:group-permission {:0 query-map} :page_size 20} | ||
| (let [flat-query (into {} | ||
| (for [[k v] query-map] | ||
| [(str "group-permission[0][" (name k) "]") v])) |
Contributor
There was a problem hiding this comment.
can you put this string key encoding into a helper and use it here and in generate-query-map-for-group-permissions
| [lein-shell "0.5.0"]] | ||
| :managed-dependencies [[at.yawk.lz4/lz4-java "1.11.1"] | ||
| [cheshire "5.12.0"] ;; latest is 6.1.0 | ||
| [cheshire "6.2.0"] ;; latest is 6.1.0 |
| cmr.elasticsearch.plugins.spatial.plugin]} | ||
| :dev {:dependencies [[criterium "0.4.4"] | ||
| [cheshire "5.12.0"] | ||
| [cheshire "6.2.0"] |
Contributor
There was a problem hiding this comment.
I forget the reason, but is parent-project not possible here?
daniel-zamora
approved these changes
Aug 31, 2026
daniel-zamora
left a comment
Contributor
There was a problem hiding this comment.
just a few nit picks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What is the objective?
Update jackson-core dep version
What are the changes?
What areas of the application does this impact?
All
Required Checklist
Additional Checklist