Skip to content

Fix #2862, correct app context in events - #2864

Merged
jphickey merged 1 commit into
nasa:devfrom
jphickey:fix-2862-tblevent
Oct 5, 2026
Merged

jphickey merged 1 commit into
nasa:devfrom
jphickey:fix-2862-tblevent

Conversation

@jphickey

Copy link
Copy Markdown
Contributor

name: FSW Code Change
about: Flight Software code changes
labels: fsw

Description of Change

Applies the same fix which was done for the table dump command to all other operations that use the same basic event-sending mechanism.

When the caller name is blank, this means it was invoked by a table services command. This changes the event to indicate it was a command rather than the "app=" empty string.

Linked Issue

Closes #2862

Requirements Impact

  • Requirement ID(s):
  • Requirements updated as necessary
  • Existing requirements are still satisfied by this change

Testing Evidence

Example event with change:
EVS Port1 1980-012-14:25:46.50482 66/1/CFE_TBL 81: Activate,tbl=TST_TBL.TestTable01:Cannot activate table, Inactive image not Validated
(the app= part is removed because it comes from tbl services itself)

Unit Tests (UT Assert)

COSMOS Test Suite

Areas of Expertise Touched

  • ASTRO
  • CI/CD
  • COSMOS
  • Cybersecurity
  • Docker
  • EDS
  • Git
  • PSPs
  • SBN
  • SMP
  • Tables
  • TSN
  • Unit Tests
  • Other

Author Checklist

  • Linked GitHub issue is referenced above
  • Code has been formatted with .clang-format
  • Static analysis workflows ran and passed
  • Unit tests (UT Assert) updated/added to cover code changes
  • Unit test workflows ran and passed
  • COSMOS test suite was run; tests updated/added if relevant changes were made
  • Requirements have been reviewed; updated or confirmed still satisfied (see above)
  • Testing evidence is included above
  • Self-review of the diff completed

Reviewer Checklist

  • Code logic is correct and matches the stated intent
  • Code is readable, maintainable, and follows project conventions (ask your lead if you are unsure of where to find these conventions)
  • .clang-format has been applied
  • Static analysis results reviewed and acceptable
  • The change has been exercised by the unit tests (not just that tests pass — the new/changed code paths are actually covered)
  • COSMOS test suite was executed against this change and results reviewed (or confirmed N/A with justification)
  • Reviewer has independently verified the change behaves as described (e.g., by running the tests locally, reviewing CI output in detail, or performing additional ad-hoc testing as warranted)
  • Memory safety reviewed (allocation, bounds, lifetime, stack usage)
  • Requirements impact reviewed and appropriate
  • Error handling is appropriate
  • Appropriate Expert areas have been reviewed

Reviewer Testing Notes

Applies the same fix which was done for the table dump command to all
other operations that use the same basic event-sending mechanism.

When the caller name is blank, this means it was invoked by a table
services command.  This changes the event to indicate it was a
command rather than the "app=" empty string.
@jphickey jphickey changed the title Fix @2862, correct app context in events Fix #2862, correct app context in events Sep 29, 2026

@wmoleski wmoleski left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good to me.

@jphickey
jphickey merged commit f22e538 into nasa:dev Oct 5, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CFE_TBL_Activate command event message missing information

3 participants