refactor(store): extract compute_merkle_path_by_ordinal helper#15962
Draft
darioush wants to merge 1 commit into
Draft
refactor(store): extract compute_merkle_path_by_ordinal helper#15962darioush wants to merge 1 commit into
darioush wants to merge 1 commit into
Conversation
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the merkle inclusion-path walk out of
MerkleProofAccess::compute_past_block_proof_in_merkle_tree_of_later_blockinto a standalonecompute_merkle_path_by_ordinalthat takes ordinal-indexed accessors (leaf hash + frontier tree). Adds a fail-fast bounds check onleaf_index < tree_size.Behavior-preserving for the existing block-merkle proof path; the new helper is reused by the upcoming SPICE light-client certified-accumulator proofs in a later PR of this stack.
Testing
merkle_proof::tests::test_no_dependency_on_blocks_outside_rangetest_block_merkle_proof,test_block_merkle_proof_same_hash(random trees across sizes)First of a 6-PR stack decomposing the SPICE light-client work (#15947).