Skip to content

fix(crypto): re-export ml_dsa_65 primitives#15969

Merged
ssavenko-near merged 3 commits into
near:masterfrom
aleksuss:fix/crypto/ml_dsa_re_export
Jun 26, 2026
Merged

fix(crypto): re-export ml_dsa_65 primitives#15969
ssavenko-near merged 3 commits into
near:masterfrom
aleksuss:fix/crypto/ml_dsa_re_export

Conversation

@aleksuss

@aleksuss aleksuss commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

The PR adds re-export for types:

  • MlDsa65PublicKey
  • MlDsa65PublicKeyHandle,
  • MlDsa65Signature,
    and the constant ML_DSA_65_PUBLIC_KEY_LENGTH.

Copilot AI review requested due to automatic review settings June 24, 2026 11:48
@aleksuss aleksuss requested a review from a team as a code owner June 24, 2026 11:48
@aleksuss aleksuss requested a review from ssavenko-near June 24, 2026 11:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds public re-exports from near_crypto for ML-DSA-65 primitives so downstream crates can use the concrete ML-DSA-65 key/signature types (and the pubkey length constant) without reaching into the private signature module. Also updates a test-only internal event-draining loop to use UnboundedReceiver::try_recv instead of try_next.

Changes:

  • Re-export MlDsa65PublicKey, MlDsa65PublicKeyHandle, MlDsa65Signature, and ML_DSA_65_PUBLIC_KEY_LENGTH from core/crypto.
  • Replace UnboundedReceiver::try_next with try_recv in ChunkExecutorActor’s testonly helper loop.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
core/crypto/src/lib.rs Re-exports additional ML-DSA-65 types/constants from the signature module.
chain/client/src/spice/chunk_executor_actor.rs Updates test-only internal event draining to use try_recv on unbounded receivers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jancionear jancionear requested a review from Wiezzel June 24, 2026 12:15
@ssavenko-near ssavenko-near enabled auto-merge June 25, 2026 13:46
@ssavenko-near ssavenko-near added this pull request to the merge queue Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.61%. Comparing base (715e0f9) to head (cfc4bd3).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15969   +/-   ##
=======================================
  Coverage   72.60%   72.61%           
=======================================
  Files         952      952           
  Lines      205109   205109           
  Branches   205109   205109           
=======================================
+ Hits       148914   148930   +16     
+ Misses      51218    51206   -12     
+ Partials     4977     4973    -4     
Flag Coverage Δ
pytests-nightly 1.10% <ø> (ø)
unittests 69.55% <ø> (+<0.01%) ⬆️
unittests-nightly 69.53% <ø> (-0.01%) ⬇️
unittests-spice 66.99% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into near:master with commit cf3e4c8 Jun 26, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants