fix(crypto): re-export ml_dsa_65 primitives#15969
Conversation
There was a problem hiding this comment.
Pull request overview
Adds public re-exports from near_crypto for ML-DSA-65 primitives so downstream crates can use the concrete ML-DSA-65 key/signature types (and the pubkey length constant) without reaching into the private signature module. Also updates a test-only internal event-draining loop to use UnboundedReceiver::try_recv instead of try_next.
Changes:
- Re-export
MlDsa65PublicKey,MlDsa65PublicKeyHandle,MlDsa65Signature, andML_DSA_65_PUBLIC_KEY_LENGTHfromcore/crypto. - Replace
UnboundedReceiver::try_nextwithtry_recvinChunkExecutorActor’stestonlyhelper loop.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/crypto/src/lib.rs | Re-exports additional ML-DSA-65 types/constants from the signature module. |
| chain/client/src/spice/chunk_executor_actor.rs | Updates test-only internal event draining to use try_recv on unbounded receivers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #15969 +/- ##
=======================================
Coverage 72.60% 72.61%
=======================================
Files 952 952
Lines 205109 205109
Branches 205109 205109
=======================================
+ Hits 148914 148930 +16
+ Misses 51218 51206 -12
+ Partials 4977 4973 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The PR adds re-export for types:
MlDsa65PublicKeyMlDsa65PublicKeyHandle,MlDsa65Signature,and the constant
ML_DSA_65_PUBLIC_KEY_LENGTH.