Report neo-node version from getversion (neo-node#983) - #1096
Open
cschuchardt88 wants to merge 3 commits into
Open
Report neo-node version from getversion (neo-node#983)#1096cschuchardt88 wants to merge 3 commits into
cschuchardt88 wants to merge 3 commits into
Conversation
UserAgent is taken from Neo.dll (LocalNode), so a 3.10.2 node still advertised 3.10.1. Add a version field from the RpcServer assembly.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master-n3 #1096 +/- ##
=============================================
+ Coverage 50.88% 50.97% +0.08%
=============================================
Files 284 284
Lines 16660 16668 +8
Branches 2137 2139 +2
=============================================
+ Hits 8477 8496 +19
+ Misses 7619 7605 -14
- Partials 564 567 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Assert version is a 3-part assembly version, rpc settings are present, and version is not the Neo.dll useragent string.
17 tasks
roman-khimov
requested changes
Aug 28, 2026
roman-khimov
left a comment
roman-khimov
left a comment
Contributor
There was a problem hiding this comment.
useragent can be just about anything, I'd rather not introduce new fields.
Drop the extra version field. Replace the version in LocalNode.UserAgent so /Neo:3.10.1/ becomes /Neo:3.10.2/ (neo-node#983).
Member
Author
|
Dropped the extra
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getversionreporteduseragentfromLocalNode.UserAgent, which is the Neo.dll assembly, not neo-cli / RpcServer. After a node bump (e.g. 3.9.2 / 3.10.2) the RPC still advertised the older library version.Fixes #983
Change
No new JSON field. The existing
useragentstring keeps the product name and uses the RpcServer assembly version (VersionPrefix), so/Neo:3.10.1/becomes/Neo:3.10.2/. Malformed useragents fall back to/Neo:{version}/.Tests
getversionhas noversionpropertyuseragentcontains the RpcServer 3-part assembly versionUserAgentWithVersionkeeps the product name and replaces the versionrpc.maxiteratorresultitems/rpc.sessionenabledmatch settingsIndependent of other neo-node branches.