fix(core): prevent partial resource cleanup when a shutdown hook rejects

[asn6878]

PR Checklist

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

• Bugfix

What is the current behavior?

Closes #17039.

When a shutdown lifecycle hook (onModuleDestroy, beforeApplicationShutdown, onApplicationShutdown) rejects, Promise.all fails fast and all remaining provider cleanup in the same module — as well as all subsequent modules — is silently skipped.

What is the new behavior?

Replace Promise.all with Promise.allSettled in the three cleanup hook functions. All providers now run their cleanup regardless of sibling failures. Rejected hooks are logged via Logger.error with stack trace. Startup hooks (onModuleInit, onApplicationBootstrap) are unchanged — fail-fast on startup remains intentional.

Does this PR introduce a breaking change?

• Yes
• No

[kamilmysliwiec]

Could you please target v12.0.0?

[asn6878]

@kamilmysliwiec I’ll handle the conflicts later today.

[asn6878]

Rebased on v12.0.0 and adapted to the new structure and test infrastructure.

The issue was filed against v11 but the same Promise.all fail-fast behavior is still there in v12.0.0's hierarchy-level for loop, so this fix applies here too.

[Copilot]

Pull request overview

This PR addresses a shutdown reliability bug in @nestjs/core where rejected shutdown lifecycle hooks could cause fail-fast behavior and skip remaining cleanup work across providers/modules.

Changes:

• Switch shutdown hook execution from Promise.all to Promise.allSettled for onModuleDestroy, beforeApplicationShutdown, and onApplicationShutdown.
• Log rejected hook errors during shutdown instead of failing fast.
• Add unit tests asserting non-throwing behavior, continued execution, and error logging for rejected provider hooks.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
packages/core/hooks/on-module-destroy.hook.ts	Uses Promise.allSettled for provider destroy hooks and logs rejections.
packages/core/hooks/on-app-shutdown.hook.ts	Uses Promise.allSettled for provider shutdown hooks and logs rejections.
packages/core/hooks/before-app-shutdown.hook.ts	Uses Promise.allSettled for provider pre-shutdown hooks and logs rejections.
packages/core/test/hooks/on-module-destroy.hook.spec.ts	Adds tests for rejected provider destroy hooks (and suggested coverage for module hook rejection).
packages/core/test/hooks/on-app-shutdown.hook.spec.ts	Adds tests for rejected provider shutdown hooks (and suggested coverage for module hook rejection).
packages/core/test/hooks/before-app-shutdown.hook.spec.ts	Adds tests for rejected provider pre-shutdown hooks (and suggested coverage for module hook rejection).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.