Add Apple iPhone device types (iPhone X through 17, SE, Air, e)#4282
Open
vince6e74 wants to merge 1 commit into
Open
Add Apple iPhone device types (iPhone X through 17, SE, Air, e)#4282vince6e74 wants to merge 1 commit into
vince6e74 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds multiple Apple iPhone device-type definitions as YAML resources, including basic physical attributes and common connectivity/power ports.
Changes:
- Added device type YAMLs for a range of iPhone models (X/XS/XR through 16 series and additional newer entries).
- Defined weights, power ports (Lightning/USB-C), and network interfaces (Cellular/Wi‑Fi/Bluetooth) for each device type.
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| device-types/Apple/iphone-x.yaml | Adds iPhone X device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-xs.yaml | Adds iPhone XS device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-xs-max.yaml | Adds iPhone XS Max device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-xr.yaml | Adds iPhone XR device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-11.yaml | Adds iPhone 11 device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-11-pro.yaml | Adds iPhone 11 Pro device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-11-pro-max.yaml | Adds iPhone 11 Pro Max device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-12.yaml | Adds iPhone 12 device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-12-mini.yaml | Adds iPhone 12 mini device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-12-pro.yaml | Adds iPhone 12 Pro device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-12-pro-max.yaml | Adds iPhone 12 Pro Max device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-13.yaml | Adds iPhone 13 device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-13-mini.yaml | Adds iPhone 13 mini device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-13-pro.yaml | Adds iPhone 13 Pro device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-13-pro-max.yaml | Adds iPhone 13 Pro Max device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-14.yaml | Adds iPhone 14 device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-14-plus.yaml | Adds iPhone 14 Plus device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-14-pro.yaml | Adds iPhone 14 Pro device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-14-pro-max.yaml | Adds iPhone 14 Pro Max device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-15.yaml | Adds iPhone 15 device-type definition (weight, USB‑C, interfaces). |
| device-types/Apple/iphone-15-plus.yaml | Adds iPhone 15 Plus device-type definition (weight, USB‑C, interfaces). |
| device-types/Apple/iphone-15-pro.yaml | Adds iPhone 15 Pro device-type definition (weight, USB‑C, interfaces). |
| device-types/Apple/iphone-15-pro-max.yaml | Adds iPhone 15 Pro Max device-type definition (weight, USB‑C, interfaces). |
| device-types/Apple/iphone-16.yaml | Adds iPhone 16 device-type definition (weight, USB‑C, interfaces). |
| device-types/Apple/iphone-16-plus.yaml | Adds iPhone 16 Plus device-type definition (weight, USB‑C, interfaces). |
| device-types/Apple/iphone-16-pro.yaml | Adds iPhone 16 Pro device-type definition (weight, USB‑C, interfaces). |
| device-types/Apple/iphone-16-pro-max.yaml | Adds iPhone 16 Pro Max device-type definition (weight, USB‑C, interfaces). |
| device-types/Apple/iphone-16e.yaml | Adds iPhone 16e device-type definition (weight, USB‑C, interfaces). |
| device-types/Apple/iphone-17.yaml | Adds iPhone 17 device-type definition (weight, USB‑C, interfaces). |
| device-types/Apple/iphone-17-pro.yaml | Adds iPhone 17 Pro device-type definition (weight, USB‑C, interfaces). |
| device-types/Apple/iphone-17-pro-max.yaml | Adds iPhone 17 Pro Max device-type definition (weight, USB‑C, interfaces). |
| device-types/Apple/iphone-17e.yaml | Adds iPhone 17e device-type definition (weight, USB‑C, interfaces). |
| device-types/Apple/iphone-air.yaml | Adds iPhone Air device-type definition (weight, USB‑C, interfaces). |
| device-types/Apple/iphone-se-1st-generation.yaml | Adds iPhone SE (1st gen) device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-se-2nd-generation.yaml | Adds iPhone SE (2nd gen) device-type definition (weight, Lightning, interfaces). |
| device-types/Apple/iphone-se-3rd-generation.yaml | Adds iPhone SE (3rd gen) device-type definition (weight, Lightning, interfaces). |
Comments suppressed due to low confidence (1)
device-types/Apple/iphone-x.yaml:1
- Using
type: otherfor the Lightning power port is less descriptive than the USB‑C entries (type: usb-c) and makes downstream filtering/reporting harder. If the schema supports a more specific type (or a structured field likedescription/label), prefer that; otherwise, consider adding a short note incommentsindicating the physical connector for consistency across all Lightning-based iPhone definitions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+16
to
+22
| interfaces: | ||
| - name: Cellular | ||
| type: 5g | ||
| - name: Wi-Fi | ||
| type: ieee802.11be | ||
| - name: Bluetooth | ||
| type: ieee802.15.1 |
Collaborator
|
@vince6e74 As per #2351 I don't think iPhones really fit in this repo |
Author
|
@harryajc I’ve included iPhones because they’re managed via MDM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 36 device-type definitions for Apple iPhones, from iPhone X up to the iPhone 17 line, including all Pro / Pro Max / Plus / mini variants as well as iPhone SE (1st–3rd generation), iPhone Air, and the 16e / 17e models.