Possible use-after-free via aliased pointer in ticket-key HMAC - #1005
Closed
normanmaurer wants to merge 1 commit into
Closed
Possible use-after-free via aliased pointer in ticket-key HMAC#1005normanmaurer wants to merge 1 commit into
normanmaurer wants to merge 1 commit into
Conversation
Motivation: current_session_key/find_session_key copies tcn_ssl_ticket_key_t by value, but mac_params[0].data still points into the original heap array, not the copy. If setSessionTicketKeys0 frees/replaces the array concurrently after the read-lock is released but before EVP_MAC_CTX_set_params dereferences it, that's a use-after-free (not a plain NULL deref, but same crash class under concurrency). Modifications: Repoint to copy Result: No more use-after-free possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
current_session_key/find_session_key copies tcn_ssl_ticket_key_t by value, but mac_params[0].data still points into the original heap array, not the copy.
If setSessionTicketKeys0 frees/replaces the array concurrently after the read-lock is released but before EVP_MAC_CTX_set_params dereferences it, that's a use-after-free (not a plain NULL deref, but same crash class under concurrency).
Modifications:
Repoint to copy
Result:
No more use-after-free possible