Repository navigation
fix: log flow rates in L/h, and give the German form its imperial units - #340
Merged
Merged
Conversation
The form takes and shows flow rates in L/h, but three log messages printed the stored value in L/min: the zero-flow fallback credit, the manual-irrigation estimate and the warning that the safety timeout will stop a run short. A user comparing the log with the form read a figure sixty times smaller than the one they had typed. They now print L/h, like the valve-test messages already did. The German catalog named only metric units in two field descriptions, in all three forms: the design flow rate did not mention gal/h, and the flow meter listed L, L/min, L/h and m3/h but not gal, gal/min and gal/h. Both now match the English text.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The form takes and shows flow rates in L/h (gal/h on an imperial instance); the value is stored in L/min. Two places did not follow that.
Log messages
Three messages printed the stored value in L/min, so a user comparing the log with the form read a figure sixty times smaller than the one they had typed. They now print L/h, as the valve-test messages already did:
controller.py);controller.py);sensor.py).No logic changes: the value is multiplied by 60 at the format call only.
German catalog
Two field descriptions named only metric units, in all three forms (setup, add zone, edit zone):
Both now match the English text.
Tests: full suite passes locally (1972 passed, 1 skipped); Ruff clean.