Integration PR for the 34.0.0 release. Combines two fixes and bumps the app version.#954
Closed
moskvin wants to merge 4 commits into
Closed
Integration PR for the 34.0.0 release. Combines two fixes and bumps the app version.#954moskvin wants to merge 4 commits into
moskvin wants to merge 4 commits into
Conversation
Signed-off-by: Niko M <nikolay.moskvin@gmail.com>
Author
|
Closing this one. It was an aggregate branch I used to build and deploy all the fixes together on my own Nextcloud server, not something meant for upstream review. The individual fixes are tracked in their proper per-repo PRs:
The combined branch stays available on my fork for anyone on NC 34 who wants to deploy all three at once while the individual PRs are in review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integration PR for the 34.0.0 release. Combines two fixes and bumps the app version.
Included
OC\Server::getL10NFactory()when app navigation is enabled #953 — Fix Internal Server Error fromOC\Server::getL10NFactory()when navigation is enabledappinfo/info.xml→ 34.0.0, NCmin 32 / max 34Notes
34.0.0 release and resolves merge order. Merge after Fix admin UI without global jQuery #952 and Fix Internal Server Error from
OC\Server::getL10NFactory()when app navigation is enabled #953 land.