feat: 🏷️ Conversation tags#2621
Draft
Ivansss wants to merge 7 commits into
Draft
Conversation
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>
SystemKeeper
left a comment
SystemKeeper
left a comment
Collaborator
There was a problem hiding this comment.
- It's weird that I can add tags in two places. IMO it should only be possible inside manage tags
- The checkmark for the tags in RoomInfo is very thin
- It feels a bit weird, that the thread tab now opens a modal, but nothing for this PR
- Downside of having archived as a pill: You don't easily spot the "dot" there anymore (is it an issue?)
- I don't like that the tags are only retrieved from the database on appReady. It takes a second to show them after app start, while the rooms are already there. Feels laggy
- Personally I don't see why we need a favorites tag 😓
Comment on lines
+1602
to
+1616
| private func isRoomMentioned(_ room: NCRoom) -> Bool { | ||
| if NCDatabaseManager.sharedInstance().serverHasTalkCapability(.directMentionFlag) { | ||
| return room.unreadMentionDirect || room.type == .oneToOne || room.type == .formerOneToOne | ||
| } | ||
|
|
||
| return room.unreadMention || room.type == .oneToOne || room.type == .formerOneToOne | ||
| } | ||
|
|
||
| private func isRoomGroupMentioned(_ room: NCRoom) -> Bool { | ||
| if NCDatabaseManager.sharedInstance().serverHasTalkCapability(.directMentionFlag) { | ||
| return room.unreadMention && !room.unreadMentionDirect | ||
| } | ||
|
|
||
| return false | ||
| } |
Collaborator
There was a problem hiding this comment.
Could move both to NCRoom?
Comment on lines
+835
to
836
| /* Create a new tag */ | ||
| "Create" = "Create"; |
Collaborator
There was a problem hiding this comment.
"Create" already exists -> shall we unify the comment?
Collaborator
|
Do need to make the bar a tad bigger or a tad more padding to the conversations? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)