Repository navigation
Seqera Platform begin request contains invalid JSON when a param value fails to serialize #7771
Description
Activity
Is that the only motivating example? Setting a legacy param to a channel? If so then I'm not sure it's worth trying to guard, considering that no one ever does this
No, that's the only one I found. I don't have a report of anyone doing it in a real pipeline. I hit it by testing legacy params with dataflow values (
channel.value(1),.collect(),.toList()); the typed case was the real-world one and #7759 covers it.The case for the guard is that the generator is a catch-and-continue that currently emits an invalid document whenever any value throws, and Platform then drops the whole begin event. Writing
nullis one line and makes that failure local to one field. If you'd rather not carry it for a case nobody hits, I'm happy to close this and the PR.
Bug report
Expected behavior and actual behavior
TowerJsonGeneratorshould always produce valid JSON. When a value fails to serialize, it logs a warning and writes the field name but no value, so the request body is invalid and the next field follows directly:"params":{"x":},"id":....This is separate from #7758/#7759, which fixed typed
Channel/Valueparams throughParamsMap.toPlainMap(). A legacy script that assigns a dataflow value to a param still hits it.Steps to reproduce the problem
channel.of(1).collect()andchannel.of(1).toList()behave the same.channel.of(1)andchannel.fromPath(..)are not affected.Program output
Captured begin payload (invalid JSON):
Environment
Additional context
The cause is the catch block in
TowerJsonGenerator.writeObject(plugins/nf-tower/src/main/io/seqera/tower/plugin/TowerJsonGenerator.groovy), which writes no value after the key has been emitted.Separately,
params.x = channel.empty()blocks the main thread inDataflowQueue.getValwhile the generator reads the channel's properties. That is a different failure and is not covered here.