Repository navigation
Improve lint errors for common gotchas - #7742
Conversation
A bare process, workflow, or agent name was given a dynamic type, so mistakes like `ch.mix(PROC)` passed the type checker. Typed workflows don't support pipes or `.out`, so referencing one as a variable is always an error. This also covers `.out`, so the separate check in the type checker is removed. Signed-off-by: Ben Sherman <bentshermann@gmail.com>
A syntax error at the end of a script or config file was reported as `Unexpected input: '<EOF>'`, which doesn't explain the mistake. It is almost always caused by an unclosed brace, bracket, parenthesis, or string, so suggest those instead. Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
|
I looked into a related issue as part of this, which is an old cryptic error about a 64 KB size limit for scripts. We added a docs note without ever digging into it It turns out there were two different limits:
So I don't think the docs notes are worth keeping since they are extreme cases. The v2 parser is the default now and it does not have the failure mode from v1 that occurred in the wild |
2 participants
This PR fixes two error messages that came up while going through nextflow-gotchas.
ch.mix(FOO)orFOO.out, now gives the errorProcess `FOO` cannot be used as a variable. This check replaces the separate.outerror inTypeCheckingVisitor.Unexpected end of file -- check for an unclosed brace, bracket, parenthesis, or string. Before, the message was a generic syntax error.Each fix is its own commit, with tests in
ScriptResolveTest,ScriptAstBuilderTest, andConfigAstBuilderTest.