Skip to content

Update llamacpppython/run module for using 0.3.28 version#11985

Open
toniher wants to merge 20 commits into
nf-core:masterfrom
biocorecrg:llamacpppython-run
Open

Update llamacpppython/run module for using 0.3.28 version#11985
toniher wants to merge 20 commits into
nf-core:masterfrom
biocorecrg:llamacpppython-run

Conversation

@toniher

@toniher toniher commented Jun 12, 2026

Copy link
Copy Markdown
Member

This pull request updates the llama-cpp-python module to use a newer version of the package (0.3.28). environment.yml and environment.gpu.yml files are simplified.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

toniher and others added 11 commits May 15, 2026 21:04
Replace pip-installed wheels with conda-forge packages for both GPU
and CPU environments. Use llama-cpp-python 0.3.28 and add explicit
cuda variant dependency for GPU environment.
Update container images to use llama-cpp-python specific containers
instead of generic python_pip containers. Downgrade llama.cpp from
version 9574 to 9222 for GPU environments to resolve compatibility
issues with the updated container images.
Update llama.cpp dependency to version 9574 and refresh container image hashes for GPU and CPU variants. Update test snapshot to reflect changes.
Remove explicit conda-forge namespace from environment files and update
container image digests to reflect the latest builds.
Update test snapshots with current timestamps and nextflow version 26.04.3. Regenerate md5 checksums for versions.yml files following test re-execution.
@toniher toniher marked this pull request as ready for review June 12, 2026 09:51
Comment thread modules/nf-core/llamacpppython/run/main.nf
toniher added 2 commits June 12, 2026 16:15
Add version extraction assertions to test snapshots for llama-cpp-python
and cuda versions. Update match() calls in GPU and CPU test files to
include version information from the versions_llama_cpp_python output.
Simplify version assertions to match full YAML object instead of
extracting individual version keys. Update snapshot files with latest
test execution timestamps and version output format.
@SPPearce

Copy link
Copy Markdown
Contributor

Please update your branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants