Skip to content

Add validation for missing bait/target intervals with picard_collecthsmetrics - #280

Open
maxulysse wants to merge 5 commits into
devfrom
fix/picard-intervals-validation
Open

Add validation for missing bait/target intervals with picard_collecthsmetrics#280
maxulysse wants to merge 5 commits into
devfrom
fix/picard-intervals-validation

Conversation

@maxulysse

@maxulysse maxulysse commented Aug 20, 2026

Copy link
Copy Markdown
Member

Add validation that fails fast with a clear error message when picard_collecthsmetrics is requested but --bait_intervals and/or --target_intervals are not provided.

Changes:

  • Added error() in PIPELINE_INITIALISATION subworkflow for missing intervals
  • Added 2 test cases (regular + stub) to tests/tools_picard.nf.test verifying the validation

Generated by opencode
Verified by @maxulysse

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 024a585

+| ✅ 202 tests passed       |+
#| ❔  10 tests were ignored |#
Details

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/linting_comment.yml
  • files_exist - File is ignored: tests/default.nf.test
  • nextflow_config - Config default ignored: params.fastq_screen_references
  • nf_test_content - nf_test_content
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/nf-core-seqinspector_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-seqinspector_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-seqinspector_logo_dark.png
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 4.1.0
  • Run at 2026-08-20 12:05:20

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

❌ nf-test failed with latest Nextflow version

Note

Tests with Nextflow's latest version failed but it will not cause a CI workflow failure.
Please check if the failure is expected with newer (edge-)releases of Nextflow or if it needs fixing.

  • docker | latest-everything | Shard 6/7

See the full run for details.

- Change missing fasta warning to error for picard/riker tools
- Add validation for riker collectors (wgs, gcbias, error, rna) that require interval files not yet supported as pipeline parameters
- Move picard missing fasta test from no_genome to tools_picard
- Add tests for riker unsupported collectors validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant