Update to Angular 21 - #3037
Conversation
| "peerDependencies": { | ||
| "@eslint/markdown": "^8.0.1", | ||
| "@ni/eslint-config-angular": "^12.0.1", | ||
| "@ni/eslint-config-angular": "../../ni-eslint-config-angular-13.0.0.tgz", |
There was a problem hiding this comment.
Need to replace this with published version, once it exists.
Dependency ReviewThe following issues were found:
|
| @@ -1,5 +1,5 @@ | |||
| import { enableProdMode } from '@angular/core'; | |||
There was a problem hiding this comment.
I poked around in the example app linked from the storybook build for this PR. Everything I tried behaved as expected except that the spright chat conversation section auto scroll stopped working. (Type "start" in the chat and it's supposed to print a scrolling message but now it prints nothing until you type another message).
I have no idea why that specifically would break with this upgrade, but I reproduced it in multiple browsers (Firefox and Edge).
There was a problem hiding this comment.
I had missed adding the provideZoneChangeDetection() to the provider. Once added, it worked locally, but didn't seem to work in the published Storybook build. I'm not 100% clear on why we were still getting a stale Storybook and/or example app build, but it's working in subsequent builds.
7a28d50 to
cc189ea
Compare
| - './packages/angular-workspace/example-client-app/src/**' | ||
| - './packages/angular-workspace/example-client-app/tsconfig.app.json' | ||
| - './packages/blazor-workspace/Examples/**' | ||
| - './packages/react-workspace/react-client-app/**' | ||
| - './packages/site/src/**' | ||
| - './packages/site/index.html' | ||
| - './packages/site/tsconfig.json' |
There was a problem hiding this comment.
talked offline, concern is this causes a full rebuild of all snapshots and this would trigger lots of snapshot rebuilds for changes unrelated to storybook snapshots / don't impact storybook snapshots
4 participants
Pull Request
🤨 Rationale
Adopting Angular 21
👩💻 Implementation
@ni/eslint-config-angular🧪 Testing
Automated tests pass.