Skip to content

Update build & target SDK to Q. #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nickbutcher wants to merge 1 commit into from
Closed

Update build & target SDK to Q. #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/src/main/java/io/plaidapp/ui/PlaidApplication.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,11 @@ package io.plaidapp.ui
import android.app.Activity
import android.app.Application
import android.content.Context
import android.os.Build.VERSION.SDK_INT
import android.os.Build.VERSION_CODES.Q
import androidx.appcompat.app.AppCompatDelegate.MODE_NIGHT_AUTO_BATTERY
import androidx.appcompat.app.AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM
import androidx.appcompat.app.AppCompatDelegate.setDefaultNightMode
import androidx.core.os.BuildCompat
import io.plaidapp.core.dagger.CoreComponent
import io.plaidapp.core.dagger.DaggerCoreComponent

Expand All @@ -33,7 +34,7 @@ class PlaidApplication : Application() {

override fun onCreate() {
super.onCreate()
val nightMode = if (BuildCompat.isAtLeastQ()) {
val nightMode = if (SDK_INT >= Q) {
MODE_NIGHT_FOLLOW_SYSTEM
} else {
MODE_NIGHT_AUTO_BATTERY
Expand Down
4 changes: 2 additions & 2 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ buildscript { scriptHandler ->
apply from: 'repositories.gradle',
to: scriptHandler
ext.versions = [
'compileSdk' : 28,
'compileSdk' : 29,
'minSdk' : 23,
'targetSdk' : 28,
'targetSdk' : 29,
'appcompat' : '1.1.0-alpha04',
'androidx' : '1.0.0',
'androidxCollection' : '1.0.0',
Expand Down