Skip to content

fix NullPointerException #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tyf1946 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix NullPointerException #733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions app/src/main/java/io/plaidapp/ui/HomeActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ class HomeActivity : AppCompatActivity() {
private lateinit var loading: ProgressBar
private lateinit var feedAdapter: FeedAdapter
private lateinit var filtersList: RecyclerView
private lateinit var mDesignerNewsLogin: MenuItem

@keyboardsurfer keyboardsurfer Jul 10, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use m prefix.

@keyboardsurfer keyboardsurfer Jul 10, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I recommend not to hold on to the item in the activity scope.

@tyf1946 tyf1946 Jul 11, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your suggestion


// data
@Inject
Expand Down Expand Up @@ -439,8 +440,7 @@ class HomeActivity : AppCompatActivity() {
}

override fun onPrepareOptionsMenu(menu: Menu): Boolean {
menu.findItem(R.id.menu_designer_news_login)
.setTitle(
mDesignerNewsLogin.setTitle(
if (viewModel.isDesignerNewsUserLoggedIn()) {
R.string.designer_news_log_out
} else {
Expand All @@ -450,6 +450,12 @@ class HomeActivity : AppCompatActivity() {
return true
}

override fun onCreateOptionsMenu(menu: Menu?): Boolean {
menuInflater.inflate(R.menu.main,menu)
mDesignerNewsLogin = menu!!.findItem(R.id.menu_designer_news_login)

@keyboardsurfer keyboardsurfer Jul 10, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use !! where it can be avoided.
In this case, checking whether menu is not null is valid.

@tyf1946 tyf1946 Jul 11, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your suggestion

return true
}

override fun onOptionsItemSelected(item: MenuItem): Boolean {
return when (item.itemId) {
R.id.menu_filter -> {
Expand Down