Skip to content

Added modifiableForEach extension method that allows for in place ListModification during traversal #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tunjid wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added modifiableForEach extension method that allows for in place ListModification during traversal #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a30d3fd
Added modifiableForEach extension method that allows for in place Lis…
tunjid Sep 11, 2019
9dc1a51
Renamed modifiableForEach to removableForEach and narrowed type to a …
tunjid Nov 26, 2019
84d1392
Renamed removableForEach to onEach
tunjid Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions core/src/main/java/io/plaidapp/core/ui/recyclerview/SlideInItemAnimator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import androidx.dynamicanimation.animation.SpringAnimation.TRANSLATION_Y
import androidx.recyclerview.widget.DefaultItemAnimator
import androidx.recyclerview.widget.RecyclerView
import io.plaidapp.core.util.listenForAllSpringsEnd
import io.plaidapp.core.util.onEach
import io.plaidapp.core.util.spring

/**
Expand Down Expand Up @@ -108,10 +109,10 @@ open class SlideInItemAnimator @JvmOverloads constructor(
}

override fun endAnimations() {
pendingAdds.forEach(::endPendingAdd)
runningAdds.forEach(::endRunningAdd)
pendingMoves.forEach(::endPendingMove)
runningMoves.forEach(::endRunningMove)
pendingAdds.onEach(::endPendingAdd)
runningAdds.onEach(::endRunningAdd)
pendingMoves.onEach(::endPendingMove)
runningMoves.onEach(::endRunningMove)
super.endAnimations()
}

Expand Down
9 changes: 9 additions & 0 deletions core/src/main/java/io/plaidapp/core/util/Extensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,12 @@ package io.plaidapp.core.util
*/
val <T> T.exhaustive: T
get() = this

/**
* A for each loop where traversal is backed by an [MutableIterator] allowing for removal
* during iteration.
*/
inline fun <T> MutableIterable<T>.onEach(action: (T) -> Unit) {
val iterator = iterator()
while (iterator.hasNext()) action(iterator.next())
}