Conversation
|
would you mind re-basing when you get the chance, please |
This commit also correct double quotes handling for properties.
This is required having disabled compile avoidance for kapt in master: kapt.include.compile.classpath=false
|
Rebase on master plus, a commit to add the main Glide artifact to kapt classpath. This is required having disabled compile avoidance for kapt in master: |
florina-muntenescu
left a comment
florina-muntenescu
left a comment
There was a problem hiding this comment.
Overall, for someone with no experience with kts, this looks good.
Maybe someone else, could take a look as well.
|
|
||
| # Use kapt in parallel | ||
| kapt.use.worker.api=true | ||
| ## Use kapt incremental |
There was a problem hiding this comment.
is this not needed anymore?
There was a problem hiding this comment.
Incremental annotation processing is enabled by default starting from version 1.3.50.
- Split the config object into three separate files based on content - Cleanup main build.gradle.kts
- Incremental annotation processing is now enabled by default - Too many kts in "build.gradle.kts.kts.kts".
keyboardsurfer
left a comment
keyboardsurfer
left a comment
There was a problem hiding this comment.
AFAICT depconstraints only hosts a build file. Does it need to be its own project for that?
| id("maven-publish") | ||
| } | ||
|
|
||
| val appcompat = "1.1.0" |
There was a problem hiding this comment.
Why arent' these constant?
There was a problem hiding this comment.
I would prefer to not put them in an object: "const val are only allowed on top level or in objects
| @Suppress("MayBeConstant") // Improve perf when changing values | ||
|
|
||
| object Libs { | ||
| val AX_ANNOTATION = "androidx.annotation:annotation:" |
There was a problem hiding this comment.
Either const & SCREAMING_SNAKE_CASE or non const & pascalCase
pfmaggi
left a comment
pfmaggi
left a comment
There was a problem hiding this comment.
This is a special components that needs to be consumed by the other modules:
https://docs.gradle.org/current/userguide/java_platform_plugin.html#sec:java_platform_consumption
e.g. it needs to be a project that can be imported:
dependencies {
// get recommended versions from the platform project
api(platform(project(":platform")))
// no version required
api("commons-httpclient:commons-httpclient")
}
4 participants
📢 Type of change
📜 Description
Moving to Kotlin DSL for the gradle build scripts.
💡 Motivation and Context
Having a single language both for the app and for its build script.
💚 How did you test it?
./gradlew check📝 Checklist
./gradlew spotlessApplybefore submitting the PR🔮 Next steps
Improve KTS design and build speed.
📸 Screenshots / GIFs