Fix eternal loading progress #719 #697 - #814
Open
QArtur99 wants to merge 6 commits into
Open
Conversation
8 tasks
Collaborator
|
Thanks for opening this. |
|
|
||
| private fun setNoFiltersEmptyTextVisibility(visibility: Int) { | ||
| noFiltersEmptyText.visibility = visibility | ||
| private fun setEmptyStateVisibility(progressBar: Int, noData: Int, noFilter: Int) { |
There was a problem hiding this comment.
@QArtur99 Please use default value for params. this will avoid setEmptyStateVisibility(View.GONE, View.GONE, View.GONE) it will become a simple call setEmptyStateVisibility() and as most of the params value is View.GONE we will not have to pass that again.
Thanks
| loading.visibility = View.VISIBLE | ||
| setNoFiltersEmptyTextVisibility(View.GONE) | ||
| if (filtersAdapter.getEnabledFilterCount() > 0) { | ||
| setEmptyStateVisibility(View.GONE, View.VISIBLE, View.GONE) |
There was a problem hiding this comment.
@QArtur99 Please consider creating extension function for view i.e fun View.visible() = visibility == View.VISIBLE and fun View.gone() = visibility == View.GONE this will be more readable.
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fix eternal refreshing and empty state in HomeActivity
Fix eternal refreshing in Search
Feat placeholder when data are not available same like for no filters
💡 Motivation and Context
When only "Product Hunt" filter was selected and no data was available from the response, the progress was showing infinitely, also function onLoadMore in InfiniteScrollListener was refreshing infinitely when data was not available.
#719
if searched data was not available, LiveData didn't trigger because data loading function didn't assign an empty list to searchResult
#697
💚 How did you test it?
Manually
📝 Checklist
./gradlew spotlessApplybefore submitting the PR🔮 Next steps
📸 Screenshots / GIFs
Edit