Skip to content

Centralize CoreComponent access method - #826

Open
nlgtuankiet wants to merge 1 commit into
nickbutcher:mainfrom
nlgtuankiet:improve-core-component
Open

Centralize CoreComponent access method#826
nlgtuankiet wants to merge 1 commit into
nickbutcher:mainfrom
nlgtuankiet:improve-core-component

Conversation

@nlgtuankiet

Copy link
Copy Markdown

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

We have several ways to access the CoreComponent, this PR centralize these methods into one.

💚 How did you test it?

Compile success + run the app where we access the CoreComponent

📝 Checklist

  • I ran ./gradlew spotlessApply before submitting the PR
  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

@googlebot

Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@nlgtuankiet

Copy link
Copy Markdown
Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@nlgtuankiet
nlgtuankiet force-pushed the improve-core-component branch from 688a05a to dd3e4c7 Compare April 14, 2020 14:53
@nlgtuankiet

Copy link
Copy Markdown
Author

is there anything else I can do? @manuelvicnt

@codingjeremy
codingjeremy changed the base branch from master to main September 29, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants