Skip to content

Bw/build cleanup - #828

Open
keyboardsurfer wants to merge 5 commits into
mainfrom
bw/buildCleanup
Open

Bw/build cleanup#828
keyboardsurfer wants to merge 5 commits into
mainfrom
bw/buildCleanup

Conversation

@keyboardsurfer

@keyboardsurfer keyboardsurfer commented Apr 27, 2020

Copy link
Copy Markdown
Collaborator

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Update dependencies and fix build warnings.
The updated dependencies allow us to run gw cAT --no-parallel. There's a failing test, which has a bug against it now (#829).

💡 Motivation and Context

💚 How did you test it?

gw cAT

📝 Checklist

  • I ran ./gradlew spotlessApply before submitting the PR
  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

Get tests fixed

📸 Screenshots / GIFs

With AGP 4.0-beta05 androidTest are working.
Even though some tests fail, namely HomeActivityTest
this is good enough for a PR to figure out
how to fix them later on.
@codingjeremy
codingjeremy changed the base branch from master to main September 29, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants